[PATCH i-g-t] RFC tests/intel/kms_frontbuffer_tracking: Introduce plane-fbc-dr test
Santhosh Reddy Guddati
santhosh.reddy.guddati at intel.com
Wed Sep 4 16:12:21 UTC 2024
Use the FP_DAMAGE_CLIPS property of the plane for non psr modes
and fill the damaged rectangles on the plane with framebuffer
cordinates and verify that fbc dirty ctl is enabled.
Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 74 ++++++++++++++++++++++++++
1 file changed, 74 insertions(+)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e45d17dd6..3b40e4a93 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -57,6 +57,10 @@
* Description: Sanity test to enable FBC on a plane.
* Functionality: fbc
*
+ * SUBTEST: plane-fbc-dr
+ * Description: Sanity test to verify FBC DR by sending multiple damaged areas with non psr modes
+ * Functionality: fbc
+ *
* SUBTEST: pipe-fbc-rte
* Description: Sanity test to enable FBC on each pipe.
* Functionality: fbc
@@ -1168,6 +1172,7 @@
*/
#define TIME SLOW_QUICK(1000, 10000)
+#define MAX_DIRTY_RECT 3
IGT_TEST_DESCRIPTION("Test the Kernel's frontbuffer tracking mechanism and "
"its related features: FBC, PSR and DRRS");
@@ -4288,6 +4293,70 @@ static int opt_handler(int option, int option_index, void *data)
return IGT_OPT_HANDLER_SUCCESS;
}
+static void fbc_dr_subtest(const struct test_mode *t) {
+ struct drm_mode_rect rect_data[MAX_DIRTY_RECT];
+ uint32_t color;
+ drmModeModeInfo *mode;
+ prepare_subtest_data(t, NULL);
+
+ igt_output_override_mode(prim_mode_params.output, &prim_mode_params.mode);
+ igt_output_set_pipe(prim_mode_params.output, prim_mode_params.pipe);
+
+ mode = igt_output_get_mode(prim_mode_params.output);
+
+ for (int i = 0; i < MAX_DIRTY_RECT; i++) {
+ // Full Frame update
+ rect_data[0].x1 = 0;
+ rect_data[0].y1 = 0;
+ rect_data[0].x2 = mode->hdisplay;
+ rect_data[0].y2 = mode->vdisplay;
+
+ // Half Frame update till last-1 scanline
+ rect_data[1].x1 = mode->hdisplay / 2;
+ rect_data[1].y1 = mode->vdisplay / 2;
+ rect_data[1].x2 = mode->hdisplay - 1;
+ rect_data[1].y2 = mode->vdisplay - 1;
+
+ // last 10 scanlines update
+ rect_data[2].x1 = mode->hdisplay - 10;
+ rect_data[2].y1 = mode->vdisplay - 10;
+ rect_data[2].x2 = mode->hdisplay - 1;
+ rect_data[2].y2 = mode->vdisplay - 1;
+
+ igt_debug("Dirty Rectangle data = {%d, %d, %d, %d}, {%d, %d, %d, %d}, {%d, %d, %d, %d}\n",
+ rect_data[0].x1, rect_data[0].y1, rect_data[0].x2, rect_data[0].y2,
+ rect_data[1].x1, rect_data[1].y1, rect_data[1].x2, rect_data[1].y2,
+ rect_data[2].x1, rect_data[2].y1, rect_data[2].x2, rect_data[2].y2);
+ }
+
+ for(int i = 0; i < MAX_DIRTY_RECT; i++) {
+ igt_plane_t *primary = igt_output_get_plane_type(prim_mode_params.output, DRM_PLANE_TYPE_PRIMARY);
+ igt_fb_t fb[MAX_DIRTY_RECT];
+
+ create_fb(t->format, prim_mode_params.mode.hdisplay, prim_mode_params.mode.vdisplay, t->tiling, t->plane, &fb[i]);
+ color = pick_color(&fb[i], COLOR_PRIM_BG);
+ igt_draw_rect_fb(drm.fd, drm.bops, 0, &fb[i], t->method,
+ rect_data[i].x1, rect_data[i].y1, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1,
+ color);
+
+ igt_plane_set_fb(primary, &fb[i]);
+ igt_plane_set_position(primary, rect_data[i].x1, rect_data[i].y1);
+ igt_plane_set_size(primary, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1);
+ igt_fb_set_size(&fb[i], primary, rect_data[i].x2 - rect_data[i].x1, rect_data[i].y2 - rect_data[i].y1);
+ igt_plane_replace_prop_blob(primary, IGT_PLANE_FB_DAMAGE_CLIPS, &rect_data[i], sizeof(rect_data[i]));
+
+ igt_display_commit_atomic(&drm.display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+ fbc_update_last_action();
+ do_assertions(ASSERT_FBC_ENABLED | ASSERT_NO_ACTION_CHANGE);
+ igt_assert_f(fbc_enable_per_plane(primary->index + 1, prim_mode_params.pipe), "FBC disabled\n");
+
+ igt_remove_fb(drm.fd, &fb[i]);
+ igt_plane_set_fb(primary, NULL);
+ igt_display_commit2(&drm.display, COMMIT_ATOMIC);
+ }
+}
+
const char *help_str =
" --no-status-check Don't check for enable/disable status\n"
" --no-crc-check Don't check for CRC values\n"
@@ -4513,6 +4582,11 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
plane_fbc_rte_subtest(&t);
}
+ igt_subtest_f("plane-fbc-dr") {
+ t.feature = FEATURE_FBC;
+ fbc_dr_subtest(&t);
+ }
+
igt_subtest_group {
igt_subtest_with_dynamic("pipe-fbc-rte") {
--
2.25.1
More information about the igt-dev
mailing list