[PATCH i-g-t] tests/amdgpu: fix a random P-state test failure

vitaly prosyak vprosyak at amd.com
Thu Sep 5 21:20:38 UTC 2024


Thanks for fixing this long-standing typo in the code. It’s been around for quite some time!

Reviewed-by: Vitaly Prosyak <vitaly.prosyak at amd.com>

On 2024-09-05 06:07, Tim Huang wrote:
> We should use the current_pstate to compare
> with the default UMD stable P-state.
>
> Signed-off-by: Tim Huang <tim.huang at amd.com>
> ---
>  tests/amdgpu/amd_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_pstate.c b/tests/amdgpu/amd_pstate.c
> index 9a7873538..2bc794252 100644
> --- a/tests/amdgpu/amd_pstate.c
> +++ b/tests/amdgpu/amd_pstate.c
> @@ -23,7 +23,7 @@ amdgpu_stable_pstate_test(amdgpu_device_handle device_handle)
>  					AMDGPU_CTX_OP_GET_STABLE_PSTATE,
>  					0, &current_pstate);
>  	igt_assert_eq(r, 0);
> -	igt_assert_eq(new_pstate, AMDGPU_CTX_STABLE_PSTATE_NONE);
> +	igt_assert_eq(current_pstate, AMDGPU_CTX_STABLE_PSTATE_NONE);
>  	r = amdgpu_cs_ctx_stable_pstate(context_handle,
>  					AMDGPU_CTX_OP_SET_STABLE_PSTATE,
>  					AMDGPU_CTX_STABLE_PSTATE_PEAK, NULL);


More information about the igt-dev mailing list