[PATCH i-g-t 3/3] lib/xe/xe_mmio: Remove redundant PCI system cleanup

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Sep 9 15:52:16 UTC 2024


Hi Marcin,
On 2024-09-04 at 10:47:01 +0200, Marcin Bernatowicz wrote:
> Remove igt_pci_system_cleanup from xe_mmio_access_fini as it cleans up
> all libpciaccess state and invalidates all handles, not just single
> xe_mmio. It should be used at the end of libpciaccess usage.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski at intel.com>
> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
> Cc: Adam Miszczak <adam.miszczak at linux.intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski at intel.com>
> Cc: K V P Satyanarayana <satyanarayana.k.v.p at intel.com>
> Cc: C V Narasimha <narasimha.c.v at intel.com>
> ---
>  lib/xe/xe_mmio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/xe/xe_mmio.c b/lib/xe/xe_mmio.c
> index 3e42b2e1c..0817c12f6 100644
> --- a/lib/xe/xe_mmio.c
> +++ b/lib/xe/xe_mmio.c
> @@ -55,7 +55,6 @@ void xe_mmio_access_fini(struct xe_mmio *mmio)
>  {
>  	mmio->intel_mmio.pci_device_id = 0;
>  	intel_mmio_unmap_pci_bar(&mmio->intel_mmio);
> -	igt_pci_system_cleanup();

What about documenting this here as a comment?

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

>  }
>  
>  /**
> -- 
> 2.31.1
> 


More information about the igt-dev mailing list