[PATCH i-g-t v1 2/5] tests/kms_plane_scaling: Add informative logs for single plane scaling operations

[Sharma, Swati2]

Hi Ramanaidu,

On 05-Sep-24 8:20 PM, Naladala Ramanaidu wrote:
> This will adds informative logging to the kms_plane_scaling test
> Logs indicating which output is being tried for scaling. When a
> required scaling operation is not supported on a particular output
> and the test is moving to the next output.
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>   tests/kms_plane_scaling.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 5c5837a51..f03a73a5e 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -1359,6 +1359,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				for_each_pipe(&data.display, pipe) {
>   					igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   						for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +							igt_info("Trying on %s\n", igt_output_name(output));
>   							if (!pipe_output_combo_valid(&data.display, pipe, output))
>   								continue;
>   							if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1370,6 +1371,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   									pipe, output);
>   							if (ret == 0)
>   								break;
> +							igt_info("Required Scaling operation not supported on %s trying on next output\n",

Nitpick: s/Scaling/scaling
Please make this change in all igt_info()
With this fixed.

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

> +								 igt_output_name(output));
>   						}
>   						igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   							      "Unsupported scaling operation in driver with return value %s\n",
> @@ -1385,6 +1388,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				for_each_pipe(&data.display, pipe) {
>   					igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   						for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +							igt_info("Trying on %s\n", igt_output_name(output));
>   							if (!pipe_output_combo_valid(&data.display, pipe, output))
>   								continue;
>   							if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1397,6 +1401,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   									pipe, output);
>   							if (ret == 0)
>   								break;
> +							igt_info("Required Scaling operation not supported on %s trying on next output\n",
> +								 igt_output_name(output));
>   						}
>   						igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   							      "Unsupported scaling operation in driver with return value %s\n",
> @@ -1412,6 +1418,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				for_each_pipe(&data.display, pipe) {
>   					igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   						for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +							igt_info("Trying on %s\n", igt_output_name(output));
>   							if (!pipe_output_combo_valid(&data.display, pipe, output))
>   								continue;
>   							if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1424,6 +1431,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   									pipe, output);
>   							if (ret == 0)
>   								break;
> +							igt_info("Required Scaling operation not supported on %s trying on next output\n",
> +								 igt_output_name(output));
>   						}
>   						igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   							      "Unsupported scaling operation in driver with return value %s\n",
> @@ -1438,6 +1447,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   			for_each_pipe(&data.display, pipe) {
>   				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   					for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +						igt_info("Trying on %s\n", igt_output_name(output));
>   						if (!pipe_output_combo_valid(&data.display, pipe, output))
>   							continue;
>   						if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1448,6 +1458,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   											 output);
>   						if (ret == 0)
>   							break;
> +						igt_info("Required Scaling operation not supported on %s trying on next output\n",
> +							 igt_output_name(output));
>   					}
>   					igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   						      "Unsupported scaling operation in driver with return value %s\n",
> @@ -1462,6 +1474,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   			for_each_pipe(&data.display, pipe) {
>   				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   					for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +						igt_info("Trying on %s\n", igt_output_name(output));
>   						if (!pipe_output_combo_valid(&data.display, pipe, output))
>   							continue;
>   						if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1472,6 +1485,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   										     output);
>   						if (ret == 0)
>   							break;
> +						igt_info("Required Scaling operation not supported on %s trying on next output\n",
> +							 igt_output_name(output));
>   					}
>   					igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   						      "Unsupported scaling operation in driver with return value %s\n",
> @@ -1485,6 +1500,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   			for_each_pipe(&data.display, pipe) {
>   				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   					for_each_valid_output_on_pipe(&data.display, pipe, output) {
> +						igt_info("Trying on %s\n", igt_output_name(output));
>   						if (!pipe_output_combo_valid(&data.display, pipe, output))
>   							continue;
>   						if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1495,6 +1511,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   										     output);
>   						if (ret == 0)
>   							break;
> +						igt_info("Required Scaling operation not supported on %s trying on next output\n",
> +							 igt_output_name(output));
>   					}
>   					igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
>   						      "Unsupported scaling operation in driver with return value %s\n",