[i-g-t 1/2] Revert "lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay"

Naladala, Ramanaidu ramanaidu.naladala at intel.com
Wed Sep 11 08:14:21 UTC 2024


Acked-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>

-----Original Message-----
From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com> 
Sent: Wednesday, September 11, 2024 1:28 PM
To: igt-dev at lists.freedesktop.org
Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
Subject: [i-g-t 1/2] Revert "lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay"

Causing regression in CI BAT.

This reverts commit 99861b72ee396a57712bbd0993f3d037cb3e7d40.

Issue: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2748
Cc: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
 lib/igt_psr.c | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/lib/igt_psr.c b/lib/igt_psr.c index 09107cd5b..4e44f44e6 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -114,28 +114,12 @@ bool psr_wait_entry(int debugfs_fd, enum psr_mode mode, igt_output_t *output)
 
 bool psr_wait_update(int debugfs_fd, enum psr_mode mode, igt_output_t *output)  {
-	/*
-	 * TODO: After enabling Panel Replay on DP2.1, observe that the SRD status
-	 * remains in the SRDENT_ON state. Remove the polling mechanism for the SRD
-	 * status change for the DP2.1 output.
-	 */
-	if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
-		return igt_wait(psr_active_check(debugfs_fd, mode, output), 40, 1);
-	else
-		return igt_wait(!psr_active_check(debugfs_fd, mode, output), 40, 1);
+	return igt_wait(!psr_active_check(debugfs_fd, mode, output), 40, 1);
 }
 
 bool psr_long_wait_update(int debugfs_fd, enum psr_mode mode, igt_output_t *output)  {
-	/*
-	 * TODO: After enabling Panel Replay on DP2.1, observe that the SRD status
-	 * remains in the SRDENT_ON state. Remove the polling mechanism for the SRD
-	 * status change for the DP2.1 output.
-	 */
-	if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
-		return igt_wait(psr_active_check(debugfs_fd, mode, output), 500, 1);
-	else
-		return igt_wait(!psr_active_check(debugfs_fd, mode, output), 500, 1);
+	return igt_wait(!psr_active_check(debugfs_fd, mode, output), 500, 1);
 }
 
 static ssize_t psr_write(int debugfs_fd, const char *buf, igt_output_t *output)
--
2.43.0



More information about the igt-dev mailing list