[PATCH i-g-t v2 4/5] test/intel/kms_pm_dc: Add psr_sink_error_check to PSR tests

Thasleem, Mohammed mohammed.thasleem at intel.com
Wed Sep 11 09:54:47 UTC 2024



-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Jouni Högander
Sent: Wednesday, September 11, 2024 11:20 AM
To: igt-dev at lists.freedesktop.org
Cc: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>
Subject: [PATCH i-g-t v2 4/5] test/intel/kms_pm_dc: Add psr_sink_error_check to PSR tests

Currently we are ignoring possible errors detected by the sink in our testcases using PSR. Fix this by add psr_sink_error_check to each of them.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>

LGTM:
Reviewed-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
---
 tests/intel/kms_pm_dc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index 07b140ce5..c87e1d408 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -407,6 +407,7 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
 	igt_require(!psr_disabled_check(data->debugfs_fd));
 	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode, NULL));
 	check_dc_counter(data, dc_flag, dc_counter_before_psr);
+	psr_sink_error_check(data->debugfs_fd, data->op_psr_mode, 
+data->output);
 	cleanup_dc_psr(data);
 }
 
@@ -693,6 +694,7 @@ static void test_pkgc_state_psr(data_t *data)
 	igt_wait((cur_value = read_pkgc_counter(data->debugfs_root_fd)) > prev_value,
 		  timeout_sec * 1000, 100);
 	igt_assert_f(cur_value > prev_value, "PKGC10 is not achieved.\n");
+	psr_sink_error_check(data->debugfs_fd, data->op_psr_mode, 
+data->output);
 	psr_dpms(data, DRM_MODE_DPMS_ON);
 	cleanup_dc_psr(data);
 }
--
2.34.1



More information about the igt-dev mailing list