[PATCH i-g-t v2 3/5] tests/intel/kms_fbt: Add psr_sink_error_check to PSR tests

Thasleem, Mohammed mohammed.thasleem at intel.com
Wed Sep 11 11:34:16 UTC 2024



-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Jouni Högander
Sent: Wednesday, September 11, 2024 11:20 AM
To: igt-dev at lists.freedesktop.org
Cc: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>
Subject: [PATCH i-g-t v2 3/5] tests/intel/kms_fbt: Add psr_sink_error_check to PSR tests

Currently we are ignoring possible errors detected by the sink in our testcases using PSR. Fix this by add psr_sink_error_check to each of them.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>

LGTM:
Reviewed-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index e45d17dd6..913c7b234 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2722,10 +2722,11 @@ static void do_status_assertions(int flags)
 						   prim_mode_params.pipe));
 	}
 
-	if (flags & ASSERT_PSR_ENABLED)
+	if (flags & ASSERT_PSR_ENABLED) {
 		igt_assert_f(psr_wait_entry(drm.debugfs, PSR_MODE_1, NULL),
 			     "PSR still disabled\n");
-	else if (flags & ASSERT_PSR_DISABLED)
+		psr_sink_error_check(drm.debugfs, PSR_MODE_1, prim_mode_params.output);
+	} else if (flags & ASSERT_PSR_DISABLED)
 		igt_assert_f(psr_wait_update(drm.debugfs, PSR_MODE_1, NULL),
 			     "PSR still enabled\n");
 }
--
2.34.1



More information about the igt-dev mailing list