[i-g-t 1/2] lib/igt_kms: Add a debug log for invalid pipe/output combo
Samala, Pranay
pranay.samala at intel.com
Wed Sep 18 08:10:08 UTC 2024
> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, September 17, 2024 3:14 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [i-g-t 1/2] lib/igt_kms: Add a debug log for invalid pipe/output combo
>
> Add some meaningful logs in case of invalid pipe/output combo.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
LGTM.
Reviewed-by: Pranay Samala <pranay.samala at intel.com>
> ---
> lib/igt_kms.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c index dd530dbab..9313e4c27 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6585,8 +6585,13 @@ bool intel_pipe_output_combo_valid(igt_display_t
> *display)
> if (output->pending_pipe == PIPE_NONE)
> continue;
>
> - if (!igt_pipe_connector_valid(output->pending_pipe, output))
> + if (!igt_pipe_connector_valid(output->pending_pipe, output)) {
> + igt_info("Output %s is disconnected (or) pipe-%s & %s
> cannot be used together\n",
> + igt_output_name(output),
> + kmstest_pipe_name(output->pending_pipe),
> + igt_output_name(output));
> return false;
> + }
>
> combo++;
> }
> --
> 2.43.0
More information about the igt-dev
mailing list