[PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests

Lucas De Marchi lucas.demarchi at intel.com
Mon Sep 23 20:58:30 UTC 2024


On Mon, Sep 23, 2024 at 11:45:53PM GMT, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
>The gen12+ check seems pointless when we already check for
>4tile specifically, so just get rid of it. Also drop the
>redundant comments.
>
>Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> tests/intel/kms_frontbuffer_tracking.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
>index f1bef9ab85ff..0646af62e51c 100644
>--- a/tests/intel/kms_frontbuffer_tracking.c
>+++ b/tests/intel/kms_frontbuffer_tracking.c
>@@ -4766,17 +4766,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>
> 					igt_require(igt_draw_supports_method(drm.fd, t.method));
>
>-					/* Tiling Y is only supported on GEN9+ */
> 					if (t.tiling == TILING_Y) {
> 						igt_require(AT_LEAST_GEN(drm.devid, 9));
> 						igt_require(!intel_get_device_info(drm.devid)->has_4tile);
> 					}
>
>-					/* Tiling 4 is only supported on GEN12+ */
>-					if (t.tiling == TILING_4) {
>-						igt_require(AT_LEAST_GEN(drm.devid, 12));
>+					if (t.tiling == TILING_4)
> 						igt_require(intel_get_device_info(drm.devid)->has_4tile);
>-					}
>
> 					if (tiling_is_valid(t.feature, t.tiling))
> 						draw_subtest(&t);
>-- 
>2.44.2
>


More information about the igt-dev mailing list