[PATCH i-g-t 1/2] tests/kms_plane_scaling: Add mode override in scaling test

Joshi, Kunal1 kunal1.joshi at intel.com
Wed Sep 25 06:08:30 UTC 2024


Hello Rama,
> -----Original Message-----
> From: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
> Sent: Tuesday, September 24, 2024 5:17 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Garg, Nemesa <nemesa.garg at intel.com>; Joshi, Kunal1
> <kunal1.joshi at intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t 1/2] tests/kms_plane_scaling: Add mode override in
> scaling test

Since this is a fix, commit subject should reflect that.
git commit --fixup sha-of-commit-introduced-this-issue

With above done.
Reviewed-by: Kunal Joshi <kunal1.joshi at intel.com>

> 
> Add a call to igt_output_override_mode to ensure the correct mode is set for
> each connector. Modify check_scaling_pipe_plane_rot function to include
> igt_output_override_mode. This change helps in accurately testing the scaling
> functionality by explicitly setting the mode before running the tests.
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>  tests/kms_plane_scaling.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c index
> bc9114acd..96ceedee2 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -585,6 +585,7 @@ check_scaling_pipe_plane_rot(data_t *d, igt_plane_t
> *plane,
> 
>  	for_each_connector_mode(output) {
>  		mode = &output->config.connector->modes[j__];
> +		igt_output_override_mode(output, mode);
>  		igt_debug("Trying mode %dx%d\n",
>  			  mode->hdisplay, mode->vdisplay);
> 
> --
> 2.43.0



More information about the igt-dev mailing list