[PATCH i-g-t 1/2] lib/igt_psr: Allow testing without checking sink status

[B, Jeevan]

> -----Original Message-----
> From: B, Jeevan
> Sent: Friday, September 27, 2024 11:58 AM
> To: Jouni Högander <jouni.hogander at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>; Hogander, Jouni
> <jouni.hogander at intel.com>
> Subject: RE: [PATCH i-g-t 1/2] lib/igt_psr: Allow testing without checking
> sink status
> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> > Jouni Högander
> > Sent: Thursday, September 26, 2024 12:35 PM
> > To: igt-dev at lists.freedesktop.org
> > Cc: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>; Hogander,
> > Jouni <jouni.hogander at intel.com>
> > Subject: [PATCH i-g-t 1/2] lib/igt_psr: Allow testing without checking
> > sink status
> >
> > We are currently seeing problems with DP2.1 display emulator devices
> > as sink Panel Replay status is not updating as expected. For this
> > purpose use environment variable (IGT_PSR_IGNORE_SINK_STATUS) to
> > disable checking sink status completely.
> >
> > Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> 
> Seeing lot of tests failing which were passing previously, Not sure it is
> related to this change please check.

Code wise LGTM, It shouldn't be affecting the test. Need to check why we are seeing failure. 
> > ---
> >  lib/igt_psr.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/igt_psr.c b/lib/igt_psr.c index d14a93534..963385967
> > 100644
> > --- a/lib/igt_psr.c
> > +++ b/lib/igt_psr.c
> > @@ -85,6 +85,7 @@ static bool psr_active_check(int debugfs_fd, enum
> > psr_mode mode, igt_output_t *o
> >  	char buf[PSR_STATUS_MAX_LEN];
> >  	drmModeConnector *c;
> >  	const char *state;
> > +	const char *env;
> >  	bool active;
> >  	int ret;
> >
> > @@ -114,7 +115,9 @@ static bool psr_active_check(int debugfs_fd, enum
> > psr_mode mode, igt_output_t *o
> >  	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
> >
> >  	active = strstr(buf, state);
> > -	if (active && output)
> > +
> > +	env = getenv("IGT_PANEL_REPLAY_IGNORE_SINK_STATUS");
> > +	if (active && output && (!env || !atoi(env)))
> >  		active = psr_active_sink_check(debugfs_fd, output);
> >
> >  	return active;
> > --
> > 2.34.1