[PATCH v2] tests/intel/xe_sysfs_timeslice_duration: Add test to validate timeslice duration

Kumar, Janga Rahul janga.rahul.kumar at intel.com
Fri Sep 27 11:38:25 UTC 2024


LGTM
Reviewed-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>

> -----Original Message-----
> From: Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
> Sent: Friday, September 27, 2024 12:11 PM
> To: igt-dev at lists.freedesktop.org; Ch, Sai Gowtham
> <sai.gowtham.ch at intel.com>; Kumar, Janga Rahul
> <janga.rahul.kumar at intel.com>
> Subject: [PATCH v2] tests/intel/xe_sysfs_timeslice_duration: Add test to validate
> timeslice duration
> 
> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> 
> Test submits two ctx and with different timeslice duration values, and checks if
> ctxs gets preempted within given timeslice duration.
> 
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> ---
>  tests/intel/xe_sysfs_timeslice_duration.c | 187 ++++++++++++++++++++++
>  tests/meson.build                         |   1 +
>  2 files changed, 188 insertions(+)
>  create mode 100644 tests/intel/xe_sysfs_timeslice_duration.c
> 
> diff --git a/tests/intel/xe_sysfs_timeslice_duration.c
> b/tests/intel/xe_sysfs_timeslice_duration.c
> new file mode 100644
> index 000000000..72ec2d273
> --- /dev/null
> +++ b/tests/intel/xe_sysfs_timeslice_duration.c
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2024 Intel Corporation
> + */
> +
> +/**
> + * TEST: sysfs timeslice duration
> + * Category: Core
> + * Mega feature: SysMan
> + * Sub-category: SysMan tests
> + * Functionality: sysfs timslice duration
> + * Feature: SMI, context
> + * Test category: SysMan
> + *
> + * SUBTEST: timeslice_duration_us-timeout
> + * Description: Test to check if the execution time of a ctx is
> + *		within the given timslice duration.
> + * Test category: functionality test
> + *
> + */
> +#include <fcntl.h>
> +
> +#include "igt.h"
> +#include "igt_syncobj.h"
> +#include "igt_sysfs.h"
> +#include "xe/xe_ioctl.h"
> +#include "xe/xe_spin.h"
> +
> +#define ATTR "timeslice_duration_us"
> +
> +static void set_timeslice_duration(int engine, unsigned int value) {
> +	unsigned int delay;
> +
> +	igt_assert_lte(0, igt_sysfs_printf(engine, ATTR, "%u", value));
> +	igt_sysfs_scanf(engine, ATTR, "%u", &delay);
> +	igt_assert_eq(delay, value);
> +}
> +
> +static uint64_t __test_timeout(int fd, int engine, unsigned int
> +timeout, uint16_t gt, int class) {
> +	struct drm_xe_sync sync = {
> +		.handle = syncobj_create(fd, 0),
> +		.type = DRM_XE_SYNC_TYPE_SYNCOBJ,
> +		.flags = DRM_XE_SYNC_FLAG_SIGNAL,
> +	};
> +
> +	struct drm_xe_exec exec = {
> +		.num_batch_buffer = 1,
> +		.num_syncs = 1,
> +		.syncs = to_user_pointer(&sync),
> +	};
> +	struct drm_xe_engine_class_instance *hwe = NULL, *_hwe;
> +	uint32_t exec_queues[2];
> +	uint32_t vm[2];
> +	uint32_t bo[2];
> +	size_t bo_size;
> +	struct xe_spin *spin[2];
> +	struct timespec ts = {};
> +	uint64_t elapsed;
> +	uint64_t addr1 = 0x1a0000, addr2 = 0x100000;
> +
> +	xe_for_each_engine(fd, _hwe)
> +		if (_hwe->engine_class == class && _hwe->gt_id == gt)
> +			hwe = _hwe;
> +	if (!hwe)
> +		return -1;
> +
> +	/* set timeslice duration*/
> +	set_timeslice_duration(engine, timeout);
> +	vm[0] = xe_vm_create(fd, 0, 0);
> +	vm[1] = xe_vm_create(fd, 0, 0);
> +	exec_queues[0] = xe_exec_queue_create(fd, vm[0], hwe, 0);
> +	exec_queues[1] = xe_exec_queue_create(fd, vm[1], hwe, 0);
> +	bo_size = xe_bb_size(fd, sizeof(*spin));
> +	bo[0] = xe_bo_create(fd, vm[0], bo_size, vram_if_possible(fd, 0), 0);
> +	spin[0] = xe_bo_map(fd, bo[0], bo_size);
> +	xe_vm_bind_async(fd, vm[0], 0, bo[0], 0, addr1, bo_size, &sync, 1);
> +	xe_spin_init_opts(spin[0], .addr = addr1, .preempt = false);
> +	exec.address = addr1;
> +	exec.exec_queue_id = exec_queues[0];
> +	xe_exec(fd, &exec);
> +	xe_spin_wait_started(spin[0]);
> +
> +	bo[1] = xe_bo_create(fd, vm[1], bo_size, vram_if_possible(fd, 0), 0);
> +	spin[1] = xe_bo_map(fd, bo[1], bo_size);
> +	xe_vm_bind_sync(fd, vm[1], bo[1], 0, addr2, bo_size);
> +	xe_spin_init_opts(spin[1], .addr = addr2);
> +	exec.address = addr2;
> +	exec.exec_queue_id = exec_queues[1];
> +	igt_nsec_elapsed(&ts);
> +	xe_exec(fd, &exec);
> +	xe_spin_wait_started(spin[1]);
> +	elapsed = igt_nsec_elapsed(&ts);
> +	xe_spin_end(spin[1]);
> +
> +	xe_vm_unbind_async(fd, vm[0], 0, 0, addr1, bo_size, &sync, 1);
> +	igt_assert(syncobj_wait(fd, &sync.handle, 1, INT64_MAX, 0, NULL));
> +
> +	xe_spin_end(spin[0]);
> +	xe_vm_unbind_sync(fd, vm[1], 0, addr2, bo_size);
> +	syncobj_destroy(fd, sync.handle);
> +
> +	xe_exec_queue_destroy(fd, exec_queues[0]);
> +	xe_vm_destroy(fd, vm[0]);
> +	xe_exec_queue_destroy(fd, exec_queues[1]);
> +	xe_vm_destroy(fd, vm[1]);
> +
> +	return elapsed;
> +}
> +
> +static void test_timeout(int fd, int engine, const char **property,
> +uint16_t class, int gt) {
> +	uint64_t delays[] = { 1000, 50000, 100000, 500000 };
> +	unsigned int saved;
> +	uint64_t elapsed;
> +	uint64_t epsilon;
> +
> +	igt_require(igt_sysfs_printf(engine, "preempt_timeout_us", "%u", 1) ==
> 1);
> +	igt_assert(igt_sysfs_scanf(engine, property[0], "%u", &saved) == 1);
> +	igt_debug("Initial %s:%u\n", property[0], saved);
> +
> +	elapsed = __test_timeout(fd, engine, 1000, gt, class);
> +	epsilon = 2 * elapsed / 1000;
> +	if (epsilon < 50000)
> +		epsilon = 50000;
> +	igt_info("Minimum timeout measured as %.3fus; setting error threshold
> to %" PRId64 "us\n",
> +
> 	elapsed * 1e-3, epsilon);
> +	igt_require(epsilon < 10000000);
> +
> +	for (int i = 0; i < ARRAY_SIZE(delays); i++) {
> +		elapsed = __test_timeout(fd, engine, delays[i], gt, class);
> +		igt_info("%s:%ld, elapsed=%.3fus\n",
> +				property[0], delays[i], elapsed * 1e-3);
> +		igt_assert_f(elapsed / 1000  < delays[i] + epsilon,
> +				"Timeslice exceeded request!!\n");
> +	}
> +
> +	set_timeslice_duration(engine, saved); }
> +
> +igt_main
> +{
> +	static const struct {
> +		const char *name;
> +		void (*fn)(int, int, const char **, uint16_t, int);
> +	} tests[] = {
> +		{ "timeout", test_timeout },
> +		{ }
> +	};
> +	const char *property[][3] = { {"timeslice_duration_us",
> +				       "timeslice_duration_min",
> +				       "timeslice_duration_max"}, };
> +	int count = sizeof(property) / sizeof(property[0]);
> +	int fd = -1, sys_fd, gt;
> +	int engines_fd = -1, gt_fd = -1;
> +
> +	igt_fixture {
> +		fd = drm_open_driver(DRIVER_XE);
> +
> +		sys_fd = igt_sysfs_open(fd);
> +		igt_require(sys_fd != -1);
> +		close(sys_fd);
> +	}
> +
> +	for (int i = 0; i < count; i++) {
> +		for (typeof(*tests) *t = tests; t->name; t++) {
> +			igt_subtest_with_dynamic_f("%s-%s", property[i][0], t-
> >name) {
> +				xe_for_each_gt(fd, gt) {
> +					gt_fd = xe_sysfs_gt_open(fd, gt);
> +					igt_require(gt_fd != -1);
> +					engines_fd = openat(gt_fd, "engines",
> O_RDONLY);
> +					igt_require(engines_fd != -1);
> +					igt_sysfs_engines(fd, engines_fd, gt, 1,
> property[i],
> +
> 	 t->fn);
> +					close(engines_fd);
> +					close(gt_fd);
> +				}
> +			}
> +		}
> +	}
> +	igt_fixture {
> +		drm_close_driver(fd);
> +	}
> +}
> +
> +
> diff --git a/tests/meson.build b/tests/meson.build index e5d8852f3..62bde353b
> 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -316,6 +316,7 @@ intel_xe_progs = [
>  	'xe_sysfs_defaults',
>  	'xe_sysfs_preempt_timeout',
>  	'xe_sysfs_scheduler',
> +        'xe_sysfs_timeslice_duration',
>  ]
> 
>  intel_xe_eudebug_progs = [
> --
> 2.25.1



More information about the igt-dev mailing list