[PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in compared_frames_dump()

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Sharma, Swati2 <swati2.sharma at intel.com>
> Sent: Friday, March 28, 2025 11:41 PM
> To: igt-dev at lists.freedesktop.org
> Cc: ville.syrjala at linux.intel.com; Shankar, Uma <uma.shankar at intel.com>;
> Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; Sharma,
> Swati2 <swati2.sharma at intel.com>
> Subject: [PATCH i-g-t 2/3] lib/igt_chamelium: Fix CRC calculation in
> compared_frames_dump()
> 
> The CRC calculation in compared_frames_dump is incorrectly using the
> reference frame instead of the captured frame when capture_crc is NULL.
> 
> Fix this by correctly passing the captured frame to
> chamelium_do_calculate_fb_crc().

LGTM

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>



> 
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
>  lib/igt_chamelium.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c index
> c86773898..a96e36b5b 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -1878,7 +1878,7 @@ static void
> compared_frames_dump(cairo_surface_t *reference,
>  	}
> 
>  	if (!capture_crc) {
> -		chamelium_do_calculate_fb_crc(reference,
> &local_capture_crc);
> +		chamelium_do_calculate_fb_crc(capture, &local_capture_crc);
>  		capture_crc = &local_capture_crc;
>  	}
> 
> --
> 2.25.1