[PATCH i-g-t v3 0/5] Refactor DRM Debug Severity Handling for

Samala, Pranay pranay.samala at intel.com
Tue Apr 1 10:04:41 UTC 2025


Hi Jani,

I accidently missed 2 words in the series subject and couldn't complete the sentence. Therefore, a new series has created for this v3.
Should I reject this version and re-send the patches as v4 or shall I keep this and update it in v4?

Regards,
Pranay

> -----Original Message-----
> From: Samala, Pranay <pranay.samala at intel.com>
> Sent: Tuesday, April 1, 2025 2:50 PM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Joshi, Kunal1 <kunal1.joshi at intel.com>;
> Lattannavar, Sameer <sameer.lattannavar at intel.com>; Samala, Pranay
> <pranay.samala at intel.com>; Leo Li <sunpeng.li at amd.com>; Nikula, Jani
> <jani.nikula at intel.com>; Shankar, Uma <uma.shankar at intel.com>; Naladala,
> Ramanaidu <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t v3 0/5] Refactor DRM Debug Severity Handling for
> 
> This update refactors the debug mask handling in the test framework for
> improved readability and addresses logical inconsistencies. Users can now pass a
> bitmask option during execution, enabling dynamic updates to the debug mask. If
> no bitmask is provided, the default value is set to 0x4.
> 
> Additionally, the exit handler has been modified to restore the original debug
> mask after the test completes, ensuring consistency. These changes enhance the
> flexibility and robustness of the DRM debug logic, making it easier to control the
> debug mask throughout the test.
> 
> v2:
> - Implementated to allow flexible bitmask usage during execution. (Jani)
> - Update the commit message (Jani)
> - Using mask to update instead of a single category (Jani)
> - To handle nested updates, exit_handler is set before the update
>   process (Jani)
> 
> v3:
> - Refactored for readability and address logical comment.
> 
> Cc: Leo Li <sunpeng.li at amd.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Uma Shankar <uma.shankar at intel.com>
> Cc: Kunal Joshi <kunal1.joshi at intel.com>
> Cc: Karthik B S <karthik.b.s at intel.com>
> Cc: Ramanaidu Naladala <ramanaidu.naladala at intel.com>
> Cc: Sameer Lattannavar <sameer.lattannavar at intel.com>
> 
> Fixes: 56b91193b825 ("lib/igt_sysfs: Implement dynamic adjustment of debug log
> level")
> Fixes: a2ab0ec12ef4 ("tests/kms_atomic_transition: Reducing debug loglevel
> dynamically")
> Fixes: 4baeb7397d71 ("tests/intel/kms_dp_linktrain_fallback: Reduce debug
> loglevel dynamically")
> Fixes: 7a8a3744466f ("tests/kms_cursor_legacy: Reduce debug loglevel
> dynamically")
> 
> Pranay Samala (5):
>   lib/igt_sysfs: Usage of Original debug mask to read/reset
>   lib/igt_sysfs: Rename debug level APIs/variables to debug mask
>   lib/igt_sysfs: Update new debug mask requested by user
>   tests/kms: Add parse_bitmask support for user
>   lib/igt_sysfs: Move igt_exit_handler into test
> 
>  lib/igt_sysfs.c                         | 64 +++++++++++++------------
>  lib/igt_sysfs.h                         |  7 +--
>  tests/intel/kms_dp_linktrain_fallback.c | 38 +++++++++++----
>  tests/kms_atomic_transition.c           | 25 +++++-----
>  tests/kms_cursor_legacy.c               | 38 +++++++++++----
>  5 files changed, 108 insertions(+), 64 deletions(-)
> 
> --
> 2.34.1



More information about the igt-dev mailing list