[PATCH i-g-t] tests/intel/perf_pmu: Remove invalid_init test for cpu

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Apr 1 15:17:38 UTC 2025


Hi Lucas,
On 2025-03-25 at 06:59:06 -0700, Lucas De Marchi wrote:
> Passing a CPU other than the cpumask should not be considered invalid.
> Since our perf-pmu has a system-wide event, it can actually be read from
> any CPU in the system, not only the one advertised in the cpumask.
> 
> See https://lore.kernel.org/all/25bc2cb3-f0ab-4e64-b331-98f52cce9a99@linux.intel.com/
> and https://lore.kernel.org/all/20240802151643.1691631-3-kan.liang@linux.intel.com/.

Remove dot from end of www address, with this
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> 
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13663
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  tests/intel/perf_pmu.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/intel/perf_pmu.c b/tests/intel/perf_pmu.c
> index a5e67ce73..bf43da8db 100644
> --- a/tests/intel/perf_pmu.c
> +++ b/tests/intel/perf_pmu.c
> @@ -1313,10 +1313,6 @@ do { \
>  	ATTR_INIT();
>  	igt_assert_eq(perf_event_open(&attr, 0, 0, -1, 0), -1);
>  	igt_assert_eq(errno, EINVAL);
> -
> -	ATTR_INIT();
> -	igt_assert_eq(perf_event_open(&attr, -1, 1, -1, 0), -1);
> -	igt_assert_eq(errno, EINVAL);
>  }
>  
>  static void open_invalid(int i915)
> -- 
> 2.49.0
> 


More information about the igt-dev mailing list