[PATCH i-g-t,v4 1/5] lib/intel_blt: Promote MEM_COPY_MOCS_SHIFT

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Tue Apr 1 19:08:56 UTC 2025


On Tue, Apr 01, 2025 at 04:00:56PM +0200, Francois Dugast wrote:
> Move MEM_COPY_MOCS_SHIFT to the header to use it elsewhere without code
> duplication.
> 
> Signed-off-by: Francois Dugast <francois.dugast at intel.com>
> ---
>  lib/intel_blt.c | 1 -
>  lib/intel_blt.h | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_blt.c b/lib/intel_blt.c
> index b2fb3151e..16e395c8f 100644
> --- a/lib/intel_blt.c
> +++ b/lib/intel_blt.c
> @@ -21,7 +21,6 @@
>  
>  #define BITRANGE(start, end) (end - start + 1)
>  #define GET_CMDS_INFO(__fd) intel_get_cmds_info(intel_get_drm_devid(__fd))
> -#define MEM_COPY_MOCS_SHIFT                     25
>  
>  /* Blitter tiling definitions sanity checks */
>  static_assert(T_LINEAR == I915_TILING_NONE, "Linear definitions have to match");
> diff --git a/lib/intel_blt.h b/lib/intel_blt.h
> index 5d6191ac9..d0ee4172d 100644
> --- a/lib/intel_blt.h
> +++ b/lib/intel_blt.h
> @@ -53,6 +53,7 @@
>  #include "intel_cmds_info.h"
>  
>  #define CCS_RATIO(fd) (intel_gen(intel_get_drm_devid(fd)) >= 20 ? 512 : 256)
> +#define MEM_COPY_MOCS_SHIFT                     25

I wondered to rename to XE2_MEM_COPY_MOCS_SHIFT to make it clear
and distinct from other gpus. But I won't oppose if you keep it
as it is.

--
Zbigniew

>  
>  enum blt_color_depth {
>  	CD_8bit,
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list