[PATCH i-g-t] tests/intel/kms_dirtyfb: Fix misplaced parenthesis in display version check

Govindapillai, Vinod vinod.govindapillai at intel.com
Fri Apr 4 08:11:13 UTC 2025


On Fri, 2025-04-04 at 10:45 +0530, Jeevan B wrote:
> Fixed a misplaced parenthesis in the FBC display version check to ensure
> correct tiling format selection.
> 
> Fixes: f0b66883398b4a07bb8fcaa3663a2140129d9a58
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> ---
>  tests/intel/kms_dirtyfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 8efa14447..a5707c5b1 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -386,7 +386,7 @@ igt_main
>  
>  					/* FBC Disp_ver 8 and below supports only
> I915_FORMAT_MOD_X_TILED */
>  					if (data.feature == FEATURE_FBC &&
> -					    intel_display_ver(intel_get_drm_devid(data.drm_fd) <=
> 8))
> +					    intel_display_ver(intel_get_drm_devid(data.drm_fd))
> <= 8)

oh.. yes. Thanks for the fix.

Reviewed-by: Vinod Govindapillai <vinod.govindapillai at intel.com>

>  						data.modifier = I915_FORMAT_MOD_X_TILED;
>  					else
>  						data.modifier = DRM_FORMAT_MOD_LINEAR;



More information about the igt-dev mailing list