[PATCH i-g-t] tests/intel/kms_dirtyfb: Fix misplaced parenthesis in display version check

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Apr 4 09:04:20 UTC 2025


Hi Sharma,,
On 2025-04-04 at 14:11:57 +0530, Sharma, Swati2 wrote:
> Hi Jeevan
> 
> On 04-04-2025 10:45 am, Jeevan B wrote:
> > Fixed a misplaced parenthesis in the FBC display version check to ensure
> > correct tiling format selection.
> > 
> > Fixes: f0b66883398b4a07bb8fcaa3663a2140129d9a58
> Fixes tag is used like this
>  Fixes: 25039689b609 ("tests/kms: Drop 'Functionality' and 'Test category'
> from
>     documentation")

And please do not split this Fixes: line, it should be one-liner.

Regards,
Kamil

> Also, do git log to get reference :)
> > Signed-off-by: Jeevan B <jeevan.b at intel.com>
> > ---
> >   tests/intel/kms_dirtyfb.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> > index 8efa14447..a5707c5b1 100644
> > --- a/tests/intel/kms_dirtyfb.c
> > +++ b/tests/intel/kms_dirtyfb.c
> > @@ -386,7 +386,7 @@ igt_main
> >   					/* FBC Disp_ver 8 and below supports only I915_FORMAT_MOD_X_TILED */
> >   					if (data.feature == FEATURE_FBC &&
> > -					    intel_display_ver(intel_get_drm_devid(data.drm_fd) <= 8))
> > +					    intel_display_ver(intel_get_drm_devid(data.drm_fd)) <= 8)
> >   						data.modifier = I915_FORMAT_MOD_X_TILED;
> >   					else
> >   						data.modifier = DRM_FORMAT_MOD_LINEAR;
> 


More information about the igt-dev mailing list