[i-g-t,v4,2/3] tests/intel/xe_fault_injection: Inject errors during xe_guc_ct_send_recv & xe_guc_mmio_send_recv.

[Lucas De Marchi]

On Fri, Apr 04, 2025 at 08:25:12AM +0200, Laguna, Lukasz wrote:
>>>>To address this problem, the environmental variable
>>>IGT_FAULT_INJECT_ITERATION
>>>
>>>I think it'd be better to use test parameter instead of environment
>>>variable. Please check igt_main_args() and consider using it.
>>>
>>Hi Lukasz,
>>  The intention of test is to inject error 0-100 iterations for guc_ct and guc_mmio functions.
>>The environment variable is used to inject error at specific iteration in case we want to debug
>>Issue in case of any failure. So, not used test parameter.
>
>I got it, but still don't see why to use environment variable instead 
>of test param.

Satya, let me help clarifying the ask from Lukasz: the intention is to
have an option to the test instead of env variable, so it's visible in
./xe_fault_injection --help. Example:

	tests/intel/xe_create.c:igt_main_args("Q:p:", NULL, help_str, opt_handler, NULL)

In the help message you can detail what it is about and that it's only
applicable on subtest XYZ, which gives more visibility than a random env
var.

thanks
Lucas De Marchi