[PATCH v1 i-g-t 1/1] tests/intel/xe_fault_injection: Inject fault for xe_hw_engine_class_to_str

[Thomas, Sobin]

Hi Kamil,

I will add r-b changes. 
This patch has dependency on the kernel fault injection code. So will be picking up after kernel changes are merged.

Regards,
Sobin Thomas

-----Original Message-----
From: Kamil Konieczny <kamil.konieczny at linux.intel.com> 
Sent: Tuesday, April 8, 2025 6:11 PM
To: Thomas, Sobin <sobin.thomas at intel.com>
Cc: igt-dev at lists.freedesktop.org; Konieczny, Kamil <kamil.konieczny at intel.com>; Piatkowski, Dominik Karol <dominik.karol.piatkowski at intel.com>
Subject: Re: [PATCH v1 i-g-t 1/1] tests/intel/xe_fault_injection: Inject fault for xe_hw_engine_class_to_str

Hi replace_with,
On 2025-04-01 at 12:06:57 +0000, replace_with Sobin Thomas wrote:
> From: Sobin Thomas <sobin.thomas at intel.com>
> 
> Use the fault injection infrastructure to make targeted fault 
> injection in functions xe_hw_engine_class_to_str and check the error 
> handling in the
> xe_hw_engine_class_sysfs_init() so that more code paths involving 
> error handling is tested.
> 
> Signed-off-by: Sobin Thomas <sobin.thomas at intel.com>

Why you did not added here r-b from Priyanka?

Also please look at report from CI for Xe.Full - there are failures for your newly added subtest, do it wait for kernel patch to be merged?
Please reply to failure mails from CI and add also CI-bug-filing team on Cc (address is given in there).

Regards,
Kamil

> ---
>  tests/intel/xe_fault_injection.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/xe_fault_injection.c 
> b/tests/intel/xe_fault_injection.c
> index 24c114ba7..94c1bbf38 100644
> --- a/tests/intel/xe_fault_injection.c
> +++ b/tests/intel/xe_fault_injection.c
> @@ -173,6 +173,7 @@ static void set_retval(const char function_name[], long long retval)
>   * @xe_guc_ct_init:		xe_guc_ct_init
>   * @xe_guc_log_init:		xe_guc_log_init
>   * @xe_guc_relay_init:		xe_guc_relay_init
> + * @xe_hw_engine_class_to_str:	xe_hw_engine_class_to_str
>   * @xe_mmio_probe_early:	xe_mmio_probe_early
>   * @xe_pcode_probe_early:	xe_pcode_probe_early
>   * @xe_pm_init_early:		xe_pm_init_early
> @@ -388,6 +389,7 @@ igt_main
>  		{ "xe_guc_ct_init" },
>  		{ "xe_guc_log_init" },
>  		{ "xe_guc_relay_init" },
> +		{ "xe_hw_engine_class_to_str" },
>  		{ "xe_mmio_probe_early" },
>  		{ "xe_pcode_probe_early" },
>  		{ "xe_pm_init_early" },
> --
> 2.34.1
>