[PATCH i-g-t v6 3/5] tools/gputop/utils: Add gputop utility functions common to all drivers

Krzysztof Karas krzysztof.karas at intel.com
Wed Apr 9 16:18:19 UTC 2025


Hi Soham,

The patch looks good, I only have one suggestion below.

[...]

> +void print_percentage_bar(double percent, int max_len)
> +{
> +	int bar_len, i, len = max_len - 1;
> +	const int w = 8;
Does 'w' stand for width? Also, if w is not meant to be changed,
this variable could be made into a symbol with #define and a
meaningful name. Regardless, if you consider that or not:

Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>

Best Regards,
Krzysztof



More information about the igt-dev mailing list