[PATCH i-g-t v6 1/5] lib/igt_device_scan: Add support for the device filter

[Krzysztof Karas]

On 2025-04-09 at 16:02:00 +0000, Krzysztof Karas wrote:
> Hi Soham,
> 
> >      Add support for the device filter based on
> > driver string, device type (integrated or discrete)
> > and card number.
> > 
> > v5 : Add device filter to filter out
> >      matching devices.           (Zbigniew)
> > 
> > v6 : Move device filter with Separate 
> >      commit.                     (Zbigniew)
> > 
> > Signed-off-by: Soham Purkait <soham.purkait at intel.com>
I forgot one thing I wanted to ask about the new filter:
"device:[driver=name][,device=type][,card=%d]"
It looks like 'device' is the same as for sriov filter (where we
have device=%04x), but here 'type' is a bit misleading I think.
Could you change that to device=%04x to match the other filter?
After that my r-b is still applicable, because other parts of
this patch look good to me.

Adding a type filter however, could be another field for future:
we could add discrecte/integrated card selection. Treat this
as food for thought rather than a request :)

Best Regards,
Krzysztof
> 
> The patch looks good:
> Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>
> 
> Best Regards,
> Krzysztof