[PATCH i-g-t 1/1] tests/xe_eudebug_online: Calculate bb_size from shader

[Piatkowski, Dominik Karol]

Hi Zbigniew,

> -----Original Message-----
> From: Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>
> Sent: Thursday, April 10, 2025 2:59 PM
> To: Piatkowski, Dominik Karol <dominik.karol.piatkowski at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Manszewski, Christoph
> <christoph.manszewski at intel.com>; Sokolowski, Jan
> <jan.sokolowski at intel.com>
> Subject: Re: [PATCH i-g-t 1/1] tests/xe_eudebug_online: Calculate bb_size
> from shader
> 
> On Thu, Apr 03, 2025 at 02:55:25PM +0200, Dominik Karol Piątkowski wrote:
> > Right now, bb_size is retrieved from get_bb_size, which returns one of
> > two hardcoded values. This approach will fail, if shader turns out to be
> > big enough to not fit into bb. Fix it by always calculating bb_size from
> > shader.
> >
> > Signed-off-by: Dominik Karol Piątkowski
> <dominik.karol.piatkowski at intel.com>
> > ---
> >  tests/intel/xe_eudebug_online.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/tests/intel/xe_eudebug_online.c
> b/tests/intel/xe_eudebug_online.c
> > index 84ba748c1..629a0ec16 100644
> > --- a/tests/intel/xe_eudebug_online.c
> > +++ b/tests/intel/xe_eudebug_online.c
> > @@ -1020,12 +1020,11 @@ static struct intel_bb
> *xe_bb_create_on_offset(int fd, uint32_t exec_queue, uint
> >  	return ibb;
> >  }
> >
> > -static size_t get_bb_size(int flags)
> > +static size_t get_bb_size(struct gpgpu_shader *shader)
> >  {
> > -	if ((flags & SHADER_CACHING_SRAM) || (flags &
> SHADER_CACHING_VRAM))
> > -		return 32768;
> > +	size_t shader_size = shader->size * sizeof(uint32_t);
> >
> > -	return 4096;
> > +	return (shader_size / PAGE_SIZE + !!(shader_size % PAGE_SIZE) + 1) *
> PAGE_SIZE;
> 
> Shouldn't this be:
> 
> ALIGN(shader_size, PAGE_SIZE) + xe_cs_prefetch_size(fd);
> 
> ?

That's very neat!
I'll send v2 soon.

Thanks,
Dominik Karol

> 
> --
> Zbigniew
> 
> >  }
> >
> >  static uint64_t get_memory_region(int fd, int flags, int region_bitmask)
> > @@ -1044,7 +1043,7 @@ static void run_online_client(struct
> xe_eudebug_client *c)
> >  	int threads = get_number_of_threads(c->flags);
> >  	const uint64_t target_offset = 0x1a000000;
> >  	const uint64_t bb_offset = 0x1b000000;
> > -	const size_t bb_size = get_bb_size(c->flags);
> > +	size_t bb_size;
> >  	struct online_debug_data *data = c->ptr;
> >  	struct drm_xe_engine_class_instance hwe = data->hwe;
> >  	struct drm_xe_ext_set_property ext = {
> > @@ -1076,6 +1075,9 @@ static void run_online_client(struct
> xe_eudebug_client *c)
> >
> >  	fd = xe_eudebug_client_open_driver(c);
> >
> > +	shader = get_shader(fd, c->flags);
> > +	bb_size = get_bb_size(shader);
> > +
> >  	/* Additional memory for steering control */
> >  	if (c->flags & SHADER_LOOP || c->flags & SHADER_SINGLE_STEP || c-
> >flags & SHADER_PAGEFAULT)
> >  		s_dim.y++;
> > @@ -1109,7 +1111,6 @@ static void run_online_client(struct
> xe_eudebug_client *c)
> >  	intel_bb_set_lr_mode(ibb, true);
> >
> >  	sip = get_sip(fd, c->flags);
> > -	shader = get_shader(fd, c->flags);
> >
> >  	igt_nsec_elapsed(&ts);
> >  	gpgpu_shader_exec(ibb, buf, w_dim.x, w_dim.y, shader, sip, 0, 0);
> > --
> > 2.34.1
> >