[PATCH i-g-t] tests/intel/intel_sysfs_debugfs: Remove xe-gt

[Peter Senna Tschudin]

The intel_sysfs_debugfs test now includes functionality to read all Xe
debugfs files, making the older xe-gt test redundant. Additionally,
xe-gt causes issues when testing Virtual Functions (VFs) in SR-IOV
setups, as some of the debugfs files it expects are not present for VFs.

Rather than extending the overlapping and problematic xe-gt, this commit
removes it entirely. Also removes xe-gt from xe-fast-feedback and from
xe-sriov-vf.blocklist.

Cc: marcin.bernatowicz at intel.com
Cc: matthew.brost at intel.com
Cc: pravalika.gurram at intel.com
Cc: kamil.konieczny at linux.intel.com
Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
Signed-off-by: Peter Senna Tschudin <peter.senna at linux.intel.com>
---
v2:
 - remove unused variables
 - remove xe-gt from lists

 tests/intel-ci/xe-fast-feedback.testlist |  1 -
 tests/intel-ci/xe-sriov-vf.blocklist.txt |  4 --
 tests/intel/intel_sysfs_debugfs.c        | 68 ------------------------
 3 files changed, 73 deletions(-)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index adc0c1b21..d9d180d87 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -10,7 +10,6 @@ igt at fbdev@write
 igt at intel_sysfs_debugfs@xe-base
 igt at intel_sysfs_debugfs@xe-debugfs-read-all-entries
 igt at intel_sysfs_debugfs@xe-forcewake
-igt at intel_sysfs_debugfs@xe-gt
 igt at intel_sysfs_debugfs@xe-sysfs-read-all-entries
 igt at kms_addfb_basic@addfb25-4-tiled
 igt at kms_addfb_basic@addfb25-bad-modifier
diff --git a/tests/intel-ci/xe-sriov-vf.blocklist.txt b/tests/intel-ci/xe-sriov-vf.blocklist.txt
index 3ee71bd83..03371d80c 100644
--- a/tests/intel-ci/xe-sriov-vf.blocklist.txt
+++ b/tests/intel-ci/xe-sriov-vf.blocklist.txt
@@ -5,7 +5,3 @@
 # Prevent potential module reloads during tests
 #
 igt at xe_module_load
-#
-# Blocked because of abort
-#
-igt at intel_sysfs_debugfs@xe-gt
diff --git a/tests/intel/intel_sysfs_debugfs.c b/tests/intel/intel_sysfs_debugfs.c
index 6beb94109..dfd8d52d8 100644
--- a/tests/intel/intel_sysfs_debugfs.c
+++ b/tests/intel/intel_sysfs_debugfs.c
@@ -322,63 +322,6 @@ xe_test_base(int fd, struct drm_xe_query_config *config)
 	xe_validate_entries(fd, "", expected_files, ARRAY_SIZE(expected_files));
 }
 
-/**
- * SUBTEST: xe-gt
- * Description: Check all gt debugfs devnodes
- * TODO: add support for ``force_reset`` entries
- */
-static void
-xe_test_gt(int fd, int gt_id)
-{
-	char name[256];
-	static const char * const expected_files[] = {
-		"uc",
-		"steering",
-		"topology",
-		"sa_info",
-		"hw_engines",
-		"pat",
-		"mocs",
-//		"force_reset"
-		"ggtt",
-		"register-save-restore",
-		"workarounds",
-		"default_lrc_rcs",
-		"default_lrc_ccs",
-		"default_lrc_bcs",
-		"default_lrc_vcs",
-		"default_lrc_vecs",
-		"hwconfig"
-
-	};
-	static const char * const expected_files_uc[] = {
-		"huc_info",
-		"guc_log",
-		"guc_info",
-//		"guc_ct_selftest"
-	};
-
-	for (int i = 0; i < ARRAY_SIZE(expected_files); i++) {
-		sprintf(name, "gt%d/%s", gt_id, expected_files[i]);
-		igt_assert(igt_debugfs_exists(fd, name, O_RDONLY));
-		if (igt_debugfs_is_dir(fd, expected_files[i], gt_id))
-			continue;
-		igt_debugfs_dump(fd, name);
-	}
-
-	for (int i = 0; i < ARRAY_SIZE(expected_files_uc); i++) {
-		sprintf(name, "gt%d/uc/%s", gt_id, expected_files_uc[i]);
-		igt_assert(igt_debugfs_exists(fd, name, O_RDONLY));
-		igt_debugfs_dump(fd, name);
-	}
-
-	sprintf(name, "/gt%d", gt_id);
-	xe_validate_entries(fd, name, expected_files, ARRAY_SIZE(expected_files));
-
-	sprintf(name, "/gt%d/uc", gt_id);
-	xe_validate_entries(fd, name, expected_files_uc, ARRAY_SIZE(expected_files_uc));
-}
-
 /**
  * SUBTEST: xe-forcewake
  * Description: Check forcewake debugfs devnode
@@ -416,9 +359,7 @@ static int opt_handler(int option, int option_index, void *input)
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	int debugfs = -1;
-	char devnode[PATH_MAX];
 	int fd = -1;
-	int gt;
 	int sysfs = -1;
 
 	igt_subtest_group {
@@ -475,15 +416,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 			xe_test_base(fd, xe_config(fd));
 		}
 
-		igt_describe("Check all gt debugfs devnodes");
-		igt_subtest("xe-gt") {
-			xe_for_each_gt(fd, gt) {
-				snprintf(devnode, sizeof(devnode), "gt%d", gt);
-				igt_require(igt_debugfs_exists(fd, devnode, O_RDONLY));
-				xe_test_gt(fd, gt);
-			}
-		}
-
 		igt_describe("Check forcewake debugfs devnode");
 		igt_subtest("xe-forcewake") {
 			xe_test_forcewake(fd);
-- 
2.43.0