[PATCH i-g-t v3 1/1] lib/xe/xe_eudebug: skip when disabling eudebug with no eudebug support

Manszewski, Christoph christoph.manszewski at intel.com
Tue Apr 15 10:50:55 UTC 2025


Hi Jan,

On 15.04.2025 11:22, Jan Sokolowski wrote:
> Tests using eudebug are not compatible with VF functionality.
> In such scenarios attempting to toggle eudebug support fails,
> which causes the test to fail, but we should instead
> skip it.
> 
> Skip a test that tries to use eudebug toggle if it doesn't
> exist.
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski at intel.com>
> Cc: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
> Cc: Christoph Manszewski <christoph.manszewski at intel.com>

Reviewed-by: Christoph Manszewski <christoph.manszewski at intel.com>

Regards,
Christoph

> ---
>   lib/xe/xe_eudebug.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/xe/xe_eudebug.c b/lib/xe/xe_eudebug.c
> index ec946058b..667c31c6e 100644
> --- a/lib/xe/xe_eudebug.c
> +++ b/lib/xe/xe_eudebug.c
> @@ -1794,10 +1794,7 @@ bool xe_eudebug_enable(int fd, bool enable)
>   	bool old = false;
>   	int ret = __xe_eudebug_enable_getset(fd, &old, &enable);
>   
> -	if (ret) {
> -		igt_skip_on(enable);
> -		old = false;
> -	}
> +	igt_skip_on(ret);
>   
>   	return old;
>   }



More information about the igt-dev mailing list