[PATCH i-g-t v6 1/3] tests/intel/xe_fault_injection: Make setup_injection_fault() programmable.

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Satyanarayana K V P
Sent: Tuesday, April 15, 2025 1:27 AM
To: igt-dev at lists.freedesktop.org
Cc: K V P, Satyanarayana <satyanarayana.k.v.p at intel.com>; Wajdeczko, Michal <Michal.Wajdeczko at intel.com>; Dugast, Francois <francois.dugast at intel.com>
Subject: [PATCH i-g-t v6 1/3] tests/intel/xe_fault_injection: Make setup_injection_fault() programmable.
> 
> The current setup_injection_fault() is always programming fixed fault
> injection parameters. Update this function to accept fault injection
> parameters for better injection capabilities.
> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
> Cc: Michał Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Francois Dugast <francois.dugast at intel.com>
> Reviewed-by: Francois Dugast <francois.dugast at intel.com>
> ---
>  tests/intel/xe_fault_injection.c | 46 +++++++++++++++++++++++++++-----
>  1 file changed, 40 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
> index fdd11ffe6..e56cdb304 100644
> --- a/tests/intel/xe_fault_injection.c
> +++ b/tests/intel/xe_fault_injection.c
> @@ -27,6 +27,18 @@
>  #define BO_ADDR		0x1a0000
>  #define BO_SIZE		(1024*1024)
>  
> +struct fault_injection_params {
> +	/* @probability: Likelihood of failure injection, in percent. */
> +	uint32_t probability;
> +	/* @interval: Specifies the interval between failures */
> +	uint32_t interval;
> +	/* @times: Specifies how many times failures may happen at most */
> +	int32_t times;
> +	/* @space: Specifies how many times fault injection is suppressed before
> +	 * first injection*/

The usual format for multi-line comments is:
"""
	/*
	 * @space: Specifies how many times fault injection is suppressed before
	 * first injection
	 */
"""
I won't block on fixing this, but I do feel I should bring this up.
-Jonathan Cavitt

> +	uint32_t space;
> +};
> +
>  static int fail_function_open(void)
>  {
>  	int debugfs_fail_function_dir_fd;
> @@ -122,21 +134,43 @@ static void injection_list_clear(void)
>  	return injection_list_add("");
>  }
>  
> +/*
> + * Default fault injection parameters which injects fault on first call to the
> + * configured fail_function.
> + */
> +static const struct fault_injection_params default_fault_params = {
> +	.probability = 100,
> +	.interval = 0,
> +	.times = -1,
> +	.space = 0
> +};
> +
>  /*
>   * See https://docs.kernel.org/fault-injection/fault-injection.html#application-examples
>   */
> -static void setup_injection_fault(void)
> +static void setup_injection_fault(const struct fault_injection_params *fault_params)
>  {
>  	int dir;
>  
> +	if (!fault_params)
> +		fault_params = &default_fault_params;
> +
> +	igt_assert(fault_params->probability >= 0);
> +	igt_assert(fault_params->probability <= 100);
> +
> +
>  	dir = fail_function_open();
>  	igt_assert_lte(0, dir);
>  
> +	igt_debug("probability = %d, interval = %d, times = %d, space = %u\n",
> +			fault_params->probability, fault_params->interval,
> +			fault_params->times, fault_params->space);
> +
>  	igt_assert_lte(0, igt_sysfs_printf(dir, "task-filter", "N"));
> -	igt_sysfs_set_u32(dir, "probability", 100);
> -	igt_sysfs_set_u32(dir, "interval", 0);
> -	igt_sysfs_set_s32(dir, "times", -1);
> -	igt_sysfs_set_u32(dir, "space", 0);
> +	igt_sysfs_set_u32(dir, "probability", fault_params->probability);
> +	igt_sysfs_set_u32(dir, "interval", fault_params->interval);
> +	igt_sysfs_set_s32(dir, "times", fault_params->times);
> +	igt_sysfs_set_u32(dir, "space", fault_params->space);
>  	igt_sysfs_set_u32(dir, "verbose", 1);
>  
>  	close(dir);
> @@ -442,7 +476,7 @@ igt_main
>  		devid = intel_get_drm_devid(fd);
>  		sysfs = igt_sysfs_open(fd);
>  		igt_device_get_pci_slot_name(fd, pci_slot);
> -		setup_injection_fault();
> +		setup_injection_fault(&default_fault_params);
>  		igt_install_exit_handler(cleanup_injection_fault);
>  	}
>  
> -- 
> 2.43.0
> 
>