[PATCH i-g-t v2 2/2] lib/amdgpu: Implement priority and secure flags for user queues

[Kamil Konieczny]

Hi Jesse.zhang,
On 2025-04-18 at 10:29:18 +0800, Jesse.zhang at amd.com wrote:
> From: "Jesse.zhang at amd.com" <Jesse.zhang at amd.com>

imho you should have space instead of dot:

> From: Jesse Zhang <Jesse.zhang at amd.com>

See also below.

> 
> This patch adds support for queue priority levels and secure queue
> creation flags in the user queue interface. The changes include:
> 
> 1. Extended the amdgpu_ring_context struct to store queue priority
> 
> 2. Modified amdgpu_user_queue_create() to:
>    - Parse and pass through priority flags from context
>    - Handle secure queue flag
>    - Include flags in queue creation IOCTL calls
> 
> The priority levels allow workloads to specify different scheduling
> priorities, with HIGH priority restricted to admin-only use. The secure
> flag enables creation of queues that can access protected content.
> 
> This matches the corresponding libdrm changes in commit fdf384d4b546
> ("amdgpu: add priority and secure flags for user queues").
> 
> add both the conditions under one if (ctxt->secure) (Sunil)
> 
> Signed-off-by: Jesse.Zhang <Jesse.zhang at amd.com>

Same here, please configure your git global config with
something like (in your home ~/.gitconfig):

[user]
        email = Jesse.zhang at amd.com
	name = Jesse Zhang

Please use this also in your first patch.

One final note at end.

> Reviewed-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>  lib/amdgpu/amd_ip_blocks.h  |  1 +
>  lib/amdgpu/amd_user_queue.c | 16 +++++++++++-----
>  2 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/amdgpu/amd_ip_blocks.h b/lib/amdgpu/amd_ip_blocks.h
> index 231098eb8..7d48f9107 100644
> --- a/lib/amdgpu/amd_ip_blocks.h
> +++ b/lib/amdgpu/amd_ip_blocks.h
>  
[...cut...]
> -- 
> 2.25.1
> 
This looks old, please update your git to somewhat newer version,
on my current machine:

git --version
git version 2.49.0

Regards,
Kamil