[PATCH v2] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests
Jonathan Cavitt
jonathan.cavitt at intel.com
Fri Apr 18 20:52:11 UTC 2025
The guard was a holdover from i915 that is not relevant to Xe because
the buffer contents are preserved during an overflow. Remove the check.
v2: Keep check for non-zero-reason test (Ashutosh)
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4541
Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
Suggested-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
---
tests/intel/xe_oa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 1fc8bfaafe..9db3d850c4 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -2503,7 +2503,8 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b
while (total_len < buf_size &&
((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 ||
(len == -1 && (errno == EINTR || errno == EIO)))) {
- if (errno == EIO) {
+ /* Assert only for default OA buffer size */
+ if (errno == EIO && !oa_buffer_size) {
oa_status = get_stream_status(stream_fd);
igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW));
}
--
2.43.0
More information about the igt-dev
mailing list