[PATCH i-g-t v2 2/2] tests/kms_async_flips: Use tiling modifiers

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Sent: Tuesday, April 22, 2025 12:09 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>
> Subject: Re: [PATCH i-g-t v2 2/2] tests/kms_async_flips: Use tiling modifiers
> 
> Hi Chaitanya,
> 
> On 21-04-2025 14:57, Borah, Chaitanya Kumar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> >> Sent: Wednesday, April 16, 2025 8:34 PM
> >> To: igt-dev at lists.freedesktop.org
> >> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> >> <arun.r.murthy at intel.com>; Borah, Chaitanya Kumar
> >> <chaitanya.kumar.borah at intel.com>; Reddy Guddati, Santhosh
> >> <santhosh.reddy.guddati at intel.com>
> >> Subject: [PATCH i-g-t v2 2/2] tests/kms_async_flips: Use tiling
> >> modifiers
> >>
> >> As async with linear modifiers is not a practical and common use
> >> case, override the default modifier with tiled for all the async flip
> >> subtests
> >>
> >> V2:
> >> move handling to default_modifier (Karthik)
> >>
> >> Signed-off-by: Santhosh Reddy Guddati
> >> <santhosh.reddy.guddati at intel.com>
> >> ---
> >>   tests/kms_async_flips.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> >> a3defe604..51afae8e9 100644
> >> --- a/tests/kms_async_flips.c
> >> +++ b/tests/kms_async_flips.c
> >> @@ -194,6 +194,9 @@ static void wait_flip_event(data_t *data)  static
> >> uint64_t default_modifier(data_t *data)  {
> >>   	if (igt_display_has_format_mod(&data->display,
> >> DRM_FORMAT_XRGB8888,
> >> +				       I915_FORMAT_MOD_4_TILED))
> >
> > This is still checking for sync format modifier pair. We perhaps need to
> change this.
> >
> > Regards
> >
> > Chaitanya
> 
> Yes, the current change is to isolate the tiled vs linear modifier subtest , and
> once below IN_FORMATS_ASYNC patch is merged ,this can be changed later
> to use async format modifiers.
> 
> https://patchwork.freedesktop.org/series/146853/

Got it! Let's keep track of this. If this patch gets merged before the IN_FORMAT_ASYNC changes, you can
perhaps add the change "igt_display_has_async_format_mod" in that series.

But for now.


Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>



> 
> Thanks,
> Santhosh
> 
> >
> >> +		return I915_FORMAT_MOD_4_TILED;
> >> +	else if (igt_display_has_format_mod(&data->display,
> >> +DRM_FORMAT_XRGB8888,
> >>   				       I915_FORMAT_MOD_X_TILED))
> >>   		return I915_FORMAT_MOD_X_TILED;
> >>   	else
> >> --
> >> 2.34.1
> >