[PATCH i-g-t v1 1/1] /tests/intel/xe_eudebug_online: Remove create_metadata_trigger on debugger reattachment.

[Manszewski, Christoph]

Hi Jan,

On 23.04.2025 13:31, Jan Sokolowski wrote:
> On debugger detach-and-reattach, discovery worker will replay events
> that have occurred, which leads to a metadata event being sent and
> create_metadata_trigger being rerun, which would then lead us
> to try to open a removed metadata.

 From what I see, the client deletes metadata only after the debugger 
reattaches and performs discovery (there is an assumption that the 
discovery will take 2 seconds, maybe that is too short?). In other 
words, the metadata access should succeed after the metadata resource 
got rediscovered.

It may well be that I am overlooking something, in that case don't 
hesitate to prove me wrong.

Regards,
Christoph

> 
> On debugger reattach trigger, remove create metadata trigger
> from list of triggers.
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski at intel.com>
> ---
>   tests/intel/xe_eudebug_online.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
> index 1f72e3e44..03b85e1ac 100644
> --- a/tests/intel/xe_eudebug_online.c
> +++ b/tests/intel/xe_eudebug_online.c
> @@ -2079,10 +2079,13 @@ static void eu_attention_debugger_detach_trigger(struct xe_eudebug_debugger *d,
>   	d->target_pid = c_pid;
>   
>   	/* Discovery worker will replay events that have occurred, which leads to
> -	 * a vm event being sent and vm_open_trigger being re-run, which would lead
> -	 * to us trying to open a removed vm. Thus, remove this trigger from list.
> +	 * some events being sent and vm_open_trigger being re-run, which would lead
> +	 * to us trying to open a removed vm. Similarly with metadata creation.
> +	 * Thus, remove these triggers from list.
>   	 */
>   	xe_eudebug_debugger_remove_trigger(d, DRM_XE_EUDEBUG_EVENT_VM, vm_open_trigger);
> +	xe_eudebug_debugger_remove_trigger(d, DRM_XE_EUDEBUG_EVENT_METADATA,
> +					   create_metadata_trigger);
>   
>   	/* Let the discovery worker discover resources */
>   	sleep(2);