[PATCH 1/5] Add stub for libunwind, procps and glib

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Apr 30 17:04:11 UTC 2025


Hi Jeevaka,
On 2025-04-29 at 20:39:56 +0000, Jeevaka Prabu Badrappan wrote:
> From: Sapna <sapna1.singh at intel.com>
> 
> As libunwind, procps, glib are not available in Android, not able to
> build igt for Android.
> 
> Provided stub implementations so igt can be compiled for both Android
> and linux from same code base. Incase of linux systems, system libraries
> will be used whereas for Android stubs will be used with reduced
> test coverage.
> 
> Signed-off-by: Sapna <sapna1.singh at intel.com>
> ---
>  include/stub/glib.h          | 43 ++++++++++++++++++++++++++++++++++++
>  include/stub/libproc2/pids.h | 41 ++++++++++++++++++++++++++++++++++
>  include/stub/libunwind.h     | 20 +++++++++++++++++

I would prefer to have this in libs itself as:

lib/igt_glib.h
lib/igt_procps.h
lib/igt_unwind.h

and fall back to system includes in case of non-Android,
like

#ifndef ANDROID

#include <glib.h>

#else

... here Android staff ...

#endif /* ANDROID */

>  3 files changed, 104 insertions(+)
>  create mode 100644 include/stub/glib.h
>  create mode 100644 include/stub/libproc2/pids.h
>  create mode 100644 include/stub/libunwind.h
> 
> diff --git a/include/stub/glib.h b/include/stub/glib.h
> new file mode 100644
> index 000000000..0bd862fa2
> --- /dev/null
> +++ b/include/stub/glib.h
> @@ -0,0 +1,43 @@
> +#pragma once

Do not use pragmas, do it C-style with:

#ifndef IGT_GLIB_H
#define IGT_GLIB_H

...

#endif

Regards,
Kamil

> +#include <stdbool.h>
> +#include <stdlib.h>
> +#define G_KEY_FILE_NONE 0
> +#define G_REGEX_OPTIMIZE 0
> +
> +typedef struct _GError {
> +    int code;
> +    char *message;
> +} GError;
> +
> +typedef struct _GKeyFile {
> +    char *key;
> +    char *value;
> +} GKeyFile;
> +
> +typedef int gint;
> +typedef size_t gsize;
> +typedef char gchar;
> +typedef unsigned char guchar;
> +typedef void GRegex;
> +
> +static inline void g_clear_error(GError **error) { }
> +static inline void g_error_free(GError *error) { }
> +static inline const char *g_get_home_dir(void) { return "/data/local/tmp/igt"; }
> +static inline void g_key_file_free(GKeyFile *file) { }
> +static inline GKeyFile *g_key_file_new(void) { return NULL; }
> +static inline int g_key_file_get_integer(GKeyFile *key_file,
> +    const char *group_name, const char *key, GError **error) { return 0; }
> +static inline char *g_key_file_get_string(GKeyFile *key_file,
> +    const char *group_name, const char *key, GError **error) { return NULL; }
> +static inline bool g_key_file_load_from_file(GKeyFile *key_file,
> +    const char *file, int flags, GError **error) { return false; }
> +static inline GRegex* g_regex_new(const char *pattern, int compile_options,
> +    int match_options, GError **error) { return NULL; }
> +static inline void g_regex_unref(GRegex *pattern) { };
> +static gchar* g_base64_encode(const guchar* data, gsize len) {
> +    gchar* str = (gchar*)malloc(1);  // Allocate memory for an empty string
> +    if (str) {
> +        str[0] = '\0';  // Set the string to be empty
> +    }
> +    return str;
> +}
> diff --git a/include/stub/libproc2/pids.h b/include/stub/libproc2/pids.h
> new file mode 100644
> index 000000000..bcdd095e0
> --- /dev/null
> +++ b/include/stub/libproc2/pids.h
> @@ -0,0 +1,41 @@
> +enum pids_item {
> +    PIDS_CMD     = 13,           //      str        stat: comm or status: Name
> +    PIDS_ID_EGID = 29,           //    u_int        status: Gid
> +    PIDS_ID_EUID = 31,           //    u_int        status: Uid
> +    PIDS_ID_PID  = 39,           //    s_int        from /proc/<pid>
> +};
> +enum pids_fetch_type {
> +    PIDS_FETCH_TASKS_ONLY,
> +    PIDS_FETCH_THREADS_TOO
> +};
> +
> +struct pids_result {
> +    enum pids_item item;
> +    union {
> +        signed char         s_ch;
> +        signed int          s_int;
> +        unsigned int        u_int;
> +        unsigned long       ul_int;
> +        unsigned long long  ull_int;
> +        char               *str;
> +        char              **strv;
> +        double              real;
> +    } result;
> +};
> +
> +struct pids_stack {
> +    struct pids_result *head;
> +};
> +
> +struct pids_info;
> +
> +#define PIDS_VAL( relative_enum, type, stack, info) \
> +    stack -> head [ relative_enum ] . result . type
> +
> +int procps_pids_new   (struct pids_info **info, enum pids_item *items, int numitems) { return 0; }
> +int procps_pids_unref (struct pids_info **info) { return 0;}
> +
> +struct pids_stack *procps_pids_get(struct pids_info *info, enum pids_fetch_type which) {
> +    struct pids_stack *ps = NULL;
> +    return ps;
> +}
> diff --git a/include/stub/libunwind.h b/include/stub/libunwind.h
> new file mode 100644
> index 000000000..168c31c14
> --- /dev/null
> +++ b/include/stub/libunwind.h
> @@ -0,0 +1,20 @@
> +#define UNW_TDEP_CURSOR_LEN     127
> +typedef struct unw_cursor
> +{
> +   int opaque[UNW_TDEP_CURSOR_LEN];
> +}
> +unw_cursor_t;
> +
> +
> +typedef struct unw_context
> +{
> +   int ctx;
> +}
> +unw_context_t;
> +
> +typedef uint32_t unw_word_t;
> +
> +int unw_getcontext(unw_context_t *uc) { return 0; }
> +int unw_init_local (unw_cursor_t *cur, unw_context_t *uc) { return 0; }
> +int unw_step (unw_cursor_t *cur) { return 0; }
> +int unw_get_proc_name (unw_cursor_t *cur, char *ch, size_t size, unw_word_t *word) { return 0; }
> -- 
> 2.49.0
> 


More information about the igt-dev mailing list