[PATCH i-g-t v2] tests/kms_cursor_crc: Rename async cursor crc subtests

Sharma, Swati2 swati2.sharma at intel.com
Tue Aug 5 08:05:28 UTC 2025


Hi Santosh,

Patch LGTM
Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

On 04-08-2025 10:26 am, Santhosh Reddy Guddati wrote:
> The original names are misleading as they suggest these tests involve
> async flips, when they actually validate cursor update timing to ensure
> no visual tearing occurs during framebuffer changes and position updates.
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>   tests/kms_cursor_crc.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 8a465dc6b..239bbd7b7 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -96,12 +96,12 @@
>    */
>   
>   /**
> - * SUBTEST: async-cursor-crc-framebuffer-change
> + * SUBTEST: cursor-tearing-framebuffer-change
>    * Description: Validate cursor IOCTLs tearing via framebuffer changes.
>    */
>   
>   /**
> - * SUBTEST: async-cursor-crc-position-change
> + * SUBTEST: cursor-tearing-position-change
>    * Description: Validate cursor IOCTLs tearing via cursor position change.
>    */
>   
> @@ -1113,8 +1113,8 @@ static void run_tests_on_pipe(data_t *data)
>   				1.f, 0.f, 0.f, &data->timed_fb[1]);
>   	}
>   
> -	igt_describe("Validate CRC with two cursors");
> -	igt_subtest_with_dynamic("async-cursor-crc-framebuffer-change") {
> +	igt_describe("Validate cursor updates don't cause tearing with framebuffer changes");
> +	igt_subtest_with_dynamic("cursor-tearing-framebuffer-change") {
>   		for_each_pipe_with_single_output(&data->display, pipe, data->output) {
>   			if (execution_constraint(pipe))
>   				continue;
> @@ -1132,8 +1132,8 @@ static void run_tests_on_pipe(data_t *data)
>   		}
>   	}
>   
> -	igt_describe("Validate CRC with two cursors and cursor position change");
> -	igt_subtest_with_dynamic("async-cursor-crc-position-change") {
> +	igt_describe("Validate cursor updates don't cause tearing with position changes");
> +	igt_subtest_with_dynamic("cursor-tearing-position-change") {
>   		for_each_pipe_with_single_output(&data->display, pipe, data->output) {
>   			if (execution_constraint(pipe))
>   				continue;



More information about the igt-dev mailing list