[PATCH i-g-t] tests/xe_compute_preempt: remove WMTP check in multiprocess tests

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Aug 11 10:45:50 UTC 2025


On Mon, Aug 11, 2025 at 12:31:36PM +0200, Kamil Konieczny wrote:
> Hi Zbigniew,
> On 2025-08-11 at 07:46:51 +0200, Zbigniew Kempczyński wrote:
> > Before forking we test WMTP preemption in test_compute_preempt()
> > which is synchronous. Remove this check as it is redundant, there's
> > dedicated 'compute-preempt' subtest which does it.
> 
> I do not see a dedicated VRAM test, only SYSTEM_RAM?
> Something like: compute-preempt-vram?

Generally on the beginning we just need to check if WMTP preemption
is supported, memory doesn't matter. Tests which -vram are testing
this functionality more thoroughly so adding compute-preempt-vram
is not increasing our coverage.

> I do not think it is a blocker so
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Thanks for the review.

--
Zbigniew

> 
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Daniel Charles <daniel.charles at intel.com>
> > ---
> >  tests/intel/xe_compute_preempt.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/tests/intel/xe_compute_preempt.c b/tests/intel/xe_compute_preempt.c
> > index 7a468e7426..c9b194869c 100644
> > --- a/tests/intel/xe_compute_preempt.c
> > +++ b/tests/intel/xe_compute_preempt.c
> > @@ -102,7 +102,6 @@ igt_main
> >  				igt_debug("RAM: %" PRIu64 ", child count: %d\n",
> >  					  ram_mb, child_count);
> >  
> > -				test_compute_preempt(xe, hwe, false, EXECENV_PREF_SYSTEM);
> >  				igt_fork(child, child_count)
> >  					test_compute_preempt(xe, hwe, false, EXECENV_PREF_SYSTEM);
> >  				igt_waitchildren();
> > @@ -129,7 +128,6 @@ igt_main
> >  				igt_debug("RAM: %" PRIu64 ", child count: %d\n",
> >  					  ram_mb, child_count);
> >  
> > -				test_compute_preempt(xe, hwe, false, EXECENV_PREF_SYSTEM);
> >  				igt_fork(child, child_count)
> >  					test_compute_preempt(xe, hwe, false, EXECENV_PREF_SYSTEM);
> >  				igt_waitchildren();
> > @@ -156,7 +154,6 @@ igt_main
> >  				igt_debug("VRAM: %" PRIu64 ", child count: %d\n",
> >  					  vram_mb, child_count);
> >  
> > -				test_compute_preempt(xe, hwe, false, EXECENV_PREF_VRAM);
> >  				igt_fork(child, child_count)
> >  					test_compute_preempt(xe, hwe, false, EXECENV_PREF_VRAM);
> >  				igt_waitchildren();
> > @@ -183,7 +180,6 @@ igt_main
> >  				igt_debug("VRAM: %" PRIu64 ", child count: %d\n",
> >  					  vram_mb, child_count);
> >  
> > -				test_compute_preempt(xe, hwe, false, EXECENV_PREF_VRAM);
> >  				igt_fork(child, child_count)
> >  					test_compute_preempt(xe, hwe, false, EXECENV_PREF_VRAM);
> >  				igt_waitchildren();
> > -- 
> > 2.43.0
> > 


More information about the igt-dev mailing list