[PATCH i-g-t] tests/kms_atomic_transition: Change debug mask for multi-output modeset tests
Naladala, Ramanaidu
Ramanaidu.naladala at intel.com
Mon Aug 11 18:51:04 UTC 2025
Hi Pranay,
On 8/5/2025 2:11 PM, Pranay Samala wrote:
> To prevent disk usage issues during CI runs with multi-output,
> this patch limits debug logging to DRM_UT_DRIVER for modeset
> transition tests when more than two outputs are connected
>
> Signed-off-by: Pranay Samala<pranay.samala at intel.com>
> ---
> tests/kms_atomic_transition.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 8c6094987..2bb2cc63b 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -1096,6 +1096,19 @@ static bool pipe_output_combo_valid(igt_display_t *display,
> return ret;
> }
>
> +static int count_conn_outputs(igt_display_t *display)
> +{
> + int conn_outputs = 0;
> + igt_output_t *output;
> +
> + for (int i = 0; i < display->n_outputs; i++) {
> + output = &display->outputs[i];
> + if (igt_output_is_connected(output))
> + conn_outputs++;
Use direct access to display->outputs[i] instead of a temporary variable.
if (igt_output_is_connected(&display->outputs[i])
> + }
> + return conn_outputs;
> +}
> +
> static int opt_handler(int opt, int opt_index, void *_data)
> {
> data_t *data = _data;
> @@ -1210,6 +1223,10 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> }
>
> for (i = 0; i < ARRAY_SIZE(transition_tests); i++) {
> + if (strcmp(transition_tests[i].name, "plane-all-modeset-transition") == 0 ||
> + strcmp(transition_tests[i].name, "plane-all-modeset-transition-fencing") == 0)
> + update_debug_mask_if_ci(DRM_UT_DRIVER);
imho, All modeset-related tests or on more display config should reduce
the log level, not just the two explicitly listed. change if condition
as below:
if(strstr(transition_tests[i].name,"modeset")||
count_conn_outputs(&data.display)>2)
> +
> igt_describe(transition_tests[i].desc);
> igt_subtest_with_dynamic_f("%s", transition_tests[i].name) {
> pipe_count = 0;
> @@ -1250,6 +1267,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> }
>
> for (i = 0; i < ARRAY_SIZE(modeset_tests); i++) {
> + if (count_conn_outputs(&data.display) > 2)
> + update_debug_mask_if_ci(DRM_UT_DRIVER);
> +
> igt_describe_f("%s", modeset_tests[i].desc);
> igt_subtest_with_dynamic_f("%s", modeset_tests[i].name) {
> for (j = 1; j <= count; j++) {
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20250812/29dac7ee/attachment.htm>
More information about the igt-dev
mailing list