[PATCH i-g-t v5 1/3] tools/intel_hdcp: Support for enabling and disabling HDCP

[Kandpal, Suraj]

> Subject: [PATCH i-g-t v5 1/3] tools/intel_hdcp: Support for enabling and
> disabling HDCP
> 
> Introduce support for enabling and disabling HDCP on specific connectors
> using command line options.
> 
> V2: Refactor logic, simplified frame buffer handling, remove update_display
> and integrate its logic to igt_output_set_hdcp().

Quite a lot of issue with this right now
To begin with this just sets HDCP either enables or disables it which is something the igt test already does
the point of the tool would be when it plays HDCP content continuously and the then HDCP Status can be enabled
and disabled at will. So this patch will require a big rework

> 
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>  tools/intel_hdcp.c | 129 ++++++++++++++++++++++++++++++++++++++++---
> --
>  1 file changed, 115 insertions(+), 14 deletions(-)
> 
> diff --git a/tools/intel_hdcp.c b/tools/intel_hdcp.c index
> 8ec698828..b9e91276f 100644
> --- a/tools/intel_hdcp.c
> +++ b/tools/intel_hdcp.c
> @@ -9,6 +9,15 @@
>  #include "igt.h"
> 
>  #define MAX_HDCP_BUF_LEN	5000
> +#define MAX_CONNECTORS		10
> +
> +#define CP_UNDESIRED		0
> +#define CP_DESIRED		1
> +#define CP_ENABLED		2
> +
> +/* Max time per authentication allowed = 6Sec */
> +#define KERNEL_AUTH_TIME_ALLOWED_MSEC		(6 * 1000)
> +#define KERNEL_DISABLE_TIME_ALLOWED_MSEC	(1 * 1000)
> 
>  typedef struct data {
>  	int fd;
> @@ -17,6 +26,79 @@ typedef struct data {
>  	int height, width;
>  } data_t;
> 
> +static void igt_output_set_hdcp(data_t *data, igt_output_t *output,
> +bool enable) {
> +	uint64_t prop_value;
> +	igt_display_t *display = &data->display;
> +	igt_plane_t *primary;
> +	drmModeModeInfo *mode;
> +
> +	mode = igt_output_get_mode(output);
> +	data->height = mode->vdisplay;
> +	data->width = mode->hdisplay;
> +
> +	igt_output_set_pipe(output, PIPE_A);

Setting this like this is wrong
Lets take the scenario of when you have a eDP and DP connected you take away the
PIPE from eDP in that case you need to add a logic to find the available pipe connector config
. This needs to on later stages be moved on to be customizable that is let the tester choose the
PIPE and connector.
Won't go into the MST Scenarios right now.

> +	primary = igt_output_get_plane_type(output,
> DRM_PLANE_TYPE_PRIMARY);
> +
> +	igt_create_color_fb(data->fd, data->width, data->height,
> +			    DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> +			    1.f, 0.f, 0.f, &data->red);
> +
> +	igt_plane_set_fb(primary, &data->red);
> +	igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +	igt_output_set_prop_value(output,
> IGT_CONNECTOR_CONTENT_PROTECTION,
> +				  enable ? CP_DESIRED : CP_UNDESIRED);
> +
> +	igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> +	if (enable) {
> +		usleep(KERNEL_AUTH_TIME_ALLOWED_MSEC);
> +		prop_value = igt_output_get_prop(output,
> +IGT_CONNECTOR_CONTENT_PROTECTION);
> +
> +		if (prop_value == CP_ENABLED) {
> +			fprintf(stderr, "HDCP enabled on output %s\n",
> output->name);
> +			/* Switch to green to indicate success */
> +			igt_create_color_fb(data->fd, data->width, data-
> >height,
> +					    DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> +					    0.f, 1.f, 0.f, &data->green);
> +			igt_plane_set_fb(primary, &data->green);
> +			igt_display_commit2(display, COMMIT_ATOMIC);
> +			igt_remove_fb(data->fd, &data->green);
> +		} else {
> +			fprintf(stderr, "Failed to enable HDCP on connector
> %s\n", output->name);
> +		}
> +	} else {
> +		usleep(KERNEL_DISABLE_TIME_ALLOWED_MSEC);
> +		prop_value = igt_output_get_prop(output,
> +IGT_CONNECTOR_CONTENT_PROTECTION);
> +
> +		if (prop_value == CP_UNDESIRED)
> +			fprintf(stderr, "HDCP disabled on connector %s\n",
> output->name);
> +		else
> +			fprintf(stderr, "Failed to disable HDCP on connector
> %s\n", output->name);
> +	}
> +
> +	igt_plane_set_fb(primary, NULL);
> +	igt_remove_fb(data->fd, &data->red);
> +	igt_output_set_pipe(output, PIPE_NONE);
> +	igt_display_commit2(display, COMMIT_ATOMIC); }
> +
> +static void set_hdcp(data_t *data, int connector_id, bool enable) {
> +	igt_output_t *output;
> +	drmModeConnector connector;
> +
> +	connector.connector_id = connector_id;
> +	output = igt_output_from_connector(&data->display, &connector);
> +	if (!output) {
> +		fprintf(stderr, "Failed to get output for connector %d\n",
> connector_id);
> +		return;
> +	}
> +
> +	igt_output_set_hdcp(data, output, enable); }
> +

All this should be in a loop where we set HDCP then change framebuffer based on if it is enabled or not
After that we should just check the connection status and keep changing the frame buffer color based on
The CP Property status.
Next this you need to introduce is a thread that listens for key presses where we can do the following
'1' to enable HDCP1.4
'2' to enable HDCP2.2 Type 0
'3' to enable HDCP 2.2 Type1
'4' to disable HDCP
Also let the Display start with HDCP disabled and let user enable what he wants
The above options can be written on the display screen itself using cairo.

Regards,
Suraj Kandpal


>  static const char *get_hdcp_version(int fd, char *connector_name)  {
>  	char buf[MAX_HDCP_BUF_LEN];
> @@ -57,24 +139,24 @@ static void get_hdcp_info(data_t *data)
>  	fprintf(stderr, "Connectors:\n");
>  	fprintf(stderr, "id\tencoder\tstatus\t\ttype\tHDCP\n");
>  	for (int i = 0; i < res->count_connectors; i++) {
> -		drmModeConnector *c;
> +		drmModeConnector *connector;
> 
> -		c = drmModeGetConnectorCurrent(data->fd, res-
> >connectors[i]);
> +		connector = drmModeGetConnectorCurrent(data->fd, res-
> >connectors[i]);
> 
> -		if (!c)
> +		if (!connector)
>  			continue;
> 
>  		asprintf(&output_name, "%s-%d",
> -			 kmstest_connector_type_str(c->connector_type),
> -			 c->connector_type_id);
> +			 kmstest_connector_type_str(connector-
> >connector_type),
> +			 connector->connector_type_id);
> 
>  		fprintf(stderr, "%d\t%d\t%s\t%s\t%s\n",
> -			c->connector_id, c->encoder_id,
> -			kmstest_connector_status_str(c->connection),
> -			kmstest_connector_type_str(c->connector_type),
> +			connector->connector_id, connector->encoder_id,
> +			kmstest_connector_status_str(connector-
> >connection),
> +			kmstest_connector_type_str(connector-
> >connector_type),
>  			get_hdcp_version(data->fd, output_name));
> 
> -		drmModeFreeConnector(c);
> +		drmModeFreeConnector(connector);
>  	}
> 
>  	drmModeFreeResources(res);
> @@ -85,7 +167,8 @@ static void print_usage(void)
>  	fprintf(stderr, "Usage: intel_hdcp [OPTIONS]\n");
>  	fprintf(stderr, "Options:\n");
>  	fprintf(stderr, "-i,	--info		Get HDCP Information\n");
> -	fprintf(stderr, "-h,	--help		Display this help
> message\n");
> +	fprintf(stderr, "-e,	--enable	Enable HDCP on the specified
> connector id\n");
> +	fprintf(stderr, "-d,	--disable	Disable HDCP on the
> specified connector id\n");
>  }
> 
>  static void test_init(data_t *data)
> @@ -103,11 +186,13 @@ int main(int argc, char **argv)  {
>  	data_t data;
>  	int option;
> -	static const char optstr[] = "hi";
> +	static const char optstr[] = "hied:";
>  	struct option long_opts[] = {
> -		{"help",	no_argument,	NULL, 'h'},
> -		{"info",	no_argument,	NULL, 'i'},
> -		{NULL,		0,		NULL,  0 }
> +		{"help",	no_argument,		NULL,	'h'},
> +		{"info",	no_argument,		NULL,	'i'},
> +		{"enable",	required_argument,	NULL,	'e'},
> +		{"disable",	required_argument,	NULL,	'd'},
> +		{NULL,		0,			NULL,	 0 }
>  	};
> 
>  	test_init(&data);
> @@ -117,6 +202,22 @@ int main(int argc, char **argv)
>  		case 'i':
>  			get_hdcp_info(&data);
>  			break;
> +		case 'e':
> +			if (!optarg) {
> +				fprintf(stderr, "Missing connector ID for
> enable\n");
> +				print_usage();
> +				exit(EXIT_FAILURE);
> +			}
> +			set_hdcp(&data, atoi(optarg), true);
> +			break;
> +		case 'd':
> +			if (!optarg) {
> +				fprintf(stderr, "Missing connector ID for
> enable\n");
> +				print_usage();
> +				exit(EXIT_FAILURE);
> +			}
> +			set_hdcp(&data, atoi(optarg), false);
> +			break;
>  		case 'h':
>  		default:
>  			print_usage();
> --
> 2.34.1