[PATCH i-g-t 1/4] tools/intel_vbt_decode: sync intel_vbt_defs.h with kernel commit bc3ca4d94369

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Aug 13 13:59:18 UTC 2025


Hi Jani,
On 2025-08-11 at 15:50:23 +0300, Jani Nikula wrote:
> Synchronize intel_vbt_defs.h with kernel commit:
> 
> bc3ca4d94369 ("drm/i915: Make I2C terminology more inclusive")
> 
> Modify the tool accordingly.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Please change subject, for example:

[PATCH i-g-t 1/4] tools/intel_vbt_decode: Change field name in structure

or
[PATCH i-g-t 1/4] tools/intel_vbt_decode: Change printed name in structure

or
[PATCH i-g-t 1/4] tools/intel_vbt_decode: Change printed name

so it will be more informative when using git log --oneline

With this
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tools/intel_vbt_decode.c | 4 ++--
>  tools/intel_vbt_defs.h   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 1b0d93d37394..85a160e08b44 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -1196,7 +1196,7 @@ static void dump_child_device(struct context *context,
>  	       dvo_port(child->dvo_port), child->dvo_port);
>  
>  	printf("\t\tAIM I2C pin: 0x%02x\n", child->i2c_pin);
> -	printf("\t\tAIM Slave address: 0x%02x\n", child->slave_addr);
> +	printf("\t\tAIM Target address: 0x%02x\n", child->target_addr);
>  	printf("\t\tDDC pin: 0x%02x\n", child->ddc_pin);
>  	printf("\t\tEDID buffer ptr: 0x%02x\n", child->edid_ptr);
>  	printf("\t\tDVO config: 0x%02x\n", child->dvo_cfg);
> @@ -1204,7 +1204,7 @@ static void dump_child_device(struct context *context,
>  	if (context->bdb->version < 155) {
>  		printf("\t\tDVO2 Port: 0x%02x (%s)\n", child->dvo2_port, dvo_port(child->dvo2_port));
>  		printf("\t\tI2C2 pin: 0x%02x\n", child->i2c2_pin);
> -		printf("\t\tSlave2 address: 0x%02x\n", child->slave2_addr);
> +		printf("\t\tTarget2 address: 0x%02x\n", child->target2_addr);
>  		printf("\t\tDDC2 pin: 0x%02x\n", child->ddc2_pin);
>  	} else {
>  		if (context->bdb->version >= 244)
> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
> index 1af8407e2081..e613288937e4 100644
> --- a/tools/intel_vbt_defs.h
> +++ b/tools/intel_vbt_defs.h
> @@ -493,7 +493,7 @@ struct child_device_config {
>  	u16 addin_offset;
>  	u8 dvo_port; /* See DEVICE_PORT_* and DVO_PORT_* above */
>  	u8 i2c_pin;
> -	u8 slave_addr;
> +	u8 target_addr;
>  	u8 ddc_pin;
>  	u16 edid_ptr;
>  	u8 dvo_cfg; /* See DEVICE_CFG_* above */
> @@ -502,7 +502,7 @@ struct child_device_config {
>  		struct {
>  			u8 dvo2_port;
>  			u8 i2c2_pin;
> -			u8 slave2_addr;
> +			u8 target2_addr;
>  			u8 ddc2_pin;
>  		} __packed;
>  		struct {
> -- 
> 2.47.2
> 


More information about the igt-dev mailing list