[PATCH i-g-t 3/4] tools/intel_vbt_decode: sync intel_vbt_defs.h with kernel commit dac2ec8d3ba2
Kamil Konieczny
kamil.konieczny at linux.intel.com
Wed Aug 13 14:12:16 UTC 2025
Hi Jani,
On 2025-08-11 at 15:50:25 +0300, Jani Nikula wrote:
please change subject, for example into:
Subject: Re: [PATCH i-g-t 3/4] tools/intel_vbt_decode: Update eDP power suquence
> Synchronize intel_vbt_defs.h with kernel commit:
>
> dac2ec8d3ba2 ("drm/i915/pps: Decouple pps delays from VBT struct definition")
>
> Modify the tool accordingly.
Write here that struct edp_power_seq was moved from intel_bios.h
into more appropriate header.
With this
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
PS. same here, no need for resend, could be done at merge time.
>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
> tools/intel_bios.h | 8 --------
> tools/intel_vbt_decode.c | 8 ++++----
> tools/intel_vbt_defs.h | 8 ++++++++
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/tools/intel_bios.h b/tools/intel_bios.h
> index fdc3308f3d38..01de2246e147 100644
> --- a/tools/intel_bios.h
> +++ b/tools/intel_bios.h
> @@ -44,14 +44,6 @@ struct bdb_legacy_child_devices {
> #define BDB_DRIVER_SDVO_LVDS 2
> #define BDB_DRIVER_EDP 3
>
> -struct edp_power_seq {
> - uint16_t t3;
> - uint16_t t7;
> - uint16_t t9;
> - uint16_t t10;
> - uint16_t t12;
> -} __attribute__ ((packed));
> -
> /* Block 52 contains MiPi Panel info
> * 6 such enteries will there. Index into correct
> * entery is based on the panel_index in #40 LFP
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 85a160e08b44..7bb3c19c3340 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -2367,12 +2367,12 @@ static void dump_edp(struct context *context,
>
> printf("\tPanel %d%s\n", i, panel_str(context, i));
>
> - printf("\t\tPower Sequence: T3 %d T7 %d T9 %d T10 %d T12 %d\n",
> - edp->power_seqs[i].t3,
> - edp->power_seqs[i].t7,
> + printf("\t\tPower Sequence: T1-T3 %d T8 %d T9 %d T10 %d T11-T12 %d\n",
> + edp->power_seqs[i].t1_t3,
> + edp->power_seqs[i].t8,
> edp->power_seqs[i].t9,
> edp->power_seqs[i].t10,
> - edp->power_seqs[i].t12);
> + edp->power_seqs[i].t11_t12);
>
> bpp = panel_bits(edp->color_depth, i, 2);
>
> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
> index 42022756bbd5..e9b809568cd4 100644
> --- a/tools/intel_vbt_defs.h
> +++ b/tools/intel_vbt_defs.h
> @@ -1014,6 +1014,14 @@ struct bdb_tv_options {
> * Block 27 - eDP VBT Block
> */
>
> +struct edp_power_seq {
> + u16 t1_t3;
> + u16 t8;
> + u16 t9;
> + u16 t10;
> + u16 t11_t12;
> +} __packed;
> +
> #define EDP_18BPP 0
> #define EDP_24BPP 1
> #define EDP_30BPP 2
> --
> 2.47.2
>
More information about the igt-dev
mailing list