[PATCH 1/2] xe/oa: Add perf consts to support more metrics

[Kamil Konieczny]

Hi Sushma,
On 2025-08-13 at 21:45:21 +0000, Sushma Venkatesh Reddy wrote:

please improve subject, add 'lib/' prefix so it will be:

[PATCH 1/2] lib/xe/oa: Add perf consts to support more metrics

> $SqidiTotalCount, $L3BankTotalCount, $L3NodeTotalCount,
> $GeometryPipeTotalCount, $DepthPipeTotalCount and $ColorPipeTotalCount are
> needed for collecting some important metrics.

Please rewrite this, first that you add new metrics, then you
could list which ones are added, for example:

Add new metrics: SqidiTotalCount, L3BankTotalCount, ...

Also adding Ashutosh to cc.
Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>

Regards,
Kamil

> 
> Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy at intel.com>
> ---
>  lib/xe/oa-configs/codegen.py | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/xe/oa-configs/codegen.py b/lib/xe/oa-configs/codegen.py
> index 8629eac6d..d3742e11b 100644
> --- a/lib/xe/oa-configs/codegen.py
> +++ b/lib/xe/oa-configs/codegen.py
> @@ -128,7 +128,6 @@ class Set:
>          return self.xml.find(path)
>  
>  
> -#TODO add SqidiTotalCount, L3BankTotalCount, L3NodeTotalCount
>  hw_vars_mapping = {
>      "$EuCoresTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
>      "$EuSlicesTotalCount": { 'c': "perf->devinfo.n_eu_slices" },
> @@ -164,6 +163,14 @@ hw_vars_mapping = {
>      "$ComputeEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
>  
>      "$CopyEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" },
> +
> +    "$SqidiTotalCount": { 'c': "perf->devinfo.n_sq_idis", 'desc': "Total number of SQIDI units" },
> +    "$L3BankTotalCount": { 'c': "perf->devinfo.l3_banks", 'desc': "Total L3 bank count" },
> +    "$L3NodeTotalCount": { 'c': "perf->devinfo.n_l3_nodes", 'desc': "Total L3 node count" },
> +
> +    "$GeometryPipeTotalCount": { 'c': "perf->devinfo.n_geom_pipes", 'desc': "The total number of geometry pipelines" },
> +    "$DepthPipeTotalCount": { 'c': "perf->devinfo.n_depth_pipes", 'desc': "The total number of depth pipelines" },
> +    "$ColorPipeTotalCount": { 'c': "perf->devinfo.n_color_pipes", 'desc': "The total number of color pipelines" },
>  }
>  
>  def is_hw_var(name):
> -- 
> 2.43.0
>