[PATCH i-g-t v3 2/2] lib/igt_kms: Add helper to get count of connected outputs

[Naladala, Ramanaidu]

Hi Pranay,

On 8/18/2025 9:46 PM, Pranay Samala wrote:
> Introduce a new helper function to return the number of
> actively connected outputs in a given igt_display_t instance.
>
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
>   lib/igt_kms.c | 19 +++++++++++++++++++
>   lib/igt_kms.h |  1 +
>   2 files changed, 20 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 7191bf92e..60e49037c 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -7519,3 +7519,22 @@ drmModePropertyBlobRes *igt_get_writeback_formats_blob(igt_output_t *output)
>   
>   	return blob;
>   }
> +
> +/**
> + * igt_get_connected_output_count:
> + * @display: pointer to igt_display_t
> + *
> + * Get the number of actively connected outputs.
> + *
> + * Returns: the count of connected outputs.
> + */
> +int igt_get_connected_output_count(igt_display_t *display)
The value here is always non-negative. Using uint32_t instead of int 
could make the intent clearer.
> +{
> +	int conn_outputs = 0;
> +
> +	for (int i = 0; i < display->n_outputs; i++) {
> +		if (igt_output_is_connected(&display->outputs[i]))
> +			conn_outputs++;
> +	}
> +	return conn_outputs;
> +}
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index f140ad91a..0dc0d622a 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1285,6 +1285,7 @@ void igt_set_link_params(int drm_fd, igt_output_t *output,
>   			   char *link_rate, char *lane_count);
>   int igt_backlight_read(int *result, const char *fname, igt_backlight_context_t *context);
>   int igt_backlight_write(int value, const char *fname, igt_backlight_context_t *context);
> +int igt_get_connected_output_count(igt_display_t *display);
>   
>   drmModePropertyBlobRes *igt_get_writeback_formats_blob(igt_output_t *output);

Overall looks good to me.

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>

>