[PATCH i-g-t] tools/xe_gpu_frequency: Add tool to set/get Intel GPU frequency for Xe

[Kamil Konieczny]

Hi Jeevaka,
On 2025-08-21 at 09:10:26 +0000, Badrappan, Jeevaka wrote:
> Hi Kamil,
> 
> > Please consider improving already existing tool intel_gpu_frequency instead of copy-paste.
> 
> There were 2 solutions considered:
> 1. Add support for Xe driver to the existing intel_gpu_frequency
> 2. Separate tool that will build on intel_gpu_frequency but specific to Xe driver
> 
> 2nd solution was chosen for the below reasons:
> - sysfs frequency path for i915 and Xe is different.

Please give example.

> - tile and gt needs to be taken into consideration.

Do we need more options here?

> - Might not be accepted due to readability because of device type checks, name based on device types, extending i915 tool to support Xe driver.
> 
> If the recommendation is to extend intel_gpu_frequency,
> can provide a patch that adds supports for Xe driver to
> existing intel_gpu_frequency tool. Please confirm.

>From user point perspective, when there are two tools it becomes
more complicated which tool to use. This one is simple enough
and imho this should stay as a one tool. 

Please try to extend existing tool first. If it will become more
complicated you could then consider splitting sources into two or
three C files but first lets see how it will fit into one.

Regards,
Kamil

> 
> > Please do not write exact output here, it could be in cover
> 
> > letter but rather not in commit message. You could add how
> 
> > it could be called into examples, when program is called with
> 
> > --help
> 
> Will address in next patch set.
> 
> 
> > +/*
> 
> > + * Copyright © 2025 Intel Corporation
> 
> > + *
> 
> > + * Permission is hereby granted, free of charge, to any person obtaining a
> 
> 
> 
> > We use SPDX licence, please look into few other tools/tests which uses them.
> 
> Will address in next patch set.
> 
> Regards,
> Jeevaka