[PATCH i-g-t 1/4] tests/intel/xe_oa: Fix report dumps in sanity check

[Umesh Nerlige Ramappa]

On Sat, Aug 23, 2025 at 11:25:07AM -0700, Dixit, Ashutosh wrote:
>On Fri, 22 Aug 2025 17:34:03 -0700, Umesh Nerlige Ramappa wrote:
>>
>
>Hi Umesh,
>
>> Fix report dumps in sanity check to dump the right amount of dwords.
>>
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
>> ---
>>  tests/intel/xe_oa.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
>> index 63b59028fc5d..35d25150ec7d 100644
>> --- a/tests/intel/xe_oa.c
>> +++ b/tests/intel/xe_oa.c
>> @@ -1052,8 +1052,8 @@ static void pec_sanity_check_reports(const u32 *report0, const u32 *report1,
>>		return;
>>	}
>>
>> -	dump_report(report0, set->perf_raw_size, "pec_report0");
>> -	dump_report(report1, set->perf_raw_size, "pec_report1");
>> +	dump_report(report0, set->perf_raw_size / 4, "pec_report0");
>> +	dump_report(report1, set->perf_raw_size / 4, "pec_report1");
>
>This is correct.
>
>>
>>	pec_sanity_check(report0, report1, set);
>>  }
>> @@ -1471,8 +1471,6 @@ read_2_oa_reports(int format_id,
>>				break;
>>			}
>>
>> -			dump_report(report, format_size / 4, "oa-formats");
>> -
>
>Not sure about this. Could you move this to a different patch with
>justification, if it's needed? I think this is there to dump Xe1 reports,
>which pec_sanity_check_reports() will not dump, though maybe for Xe2 it
>double dumps? I'd rather have more data there for debug, rather than data
>missing.

oh, I removed it since I saw double dumps. Let me recheck this one.

Thanks,
Umesh
>
>>			igt_debug("read report: reason = %x, timestamp = %"PRIx64", exponent mask=%x\n",
>>				  report[0], oa_timestamp(report, format_id), exponent_mask);
>>
>> --
>> 2.43.0
>>
>
>Thanks.
>--
>Ashutosh