[PATCH i-g-t 1/1] tests/xe_evict_ccs:Adjust object size as per VRAM

[Kamil Konieczny]

Hi Sobin,
On 2025-08-26 at 05:50:49 +0000, Sobin Thomas wrote:

change subject, add 'intel/' prefix, also add space after ':'
so it will be like:

[PATCH i-g-t 1/1] tests/intel/xe_evict_ccs: Adjust object size as per VRAM

> Some BIOS configurations do not support or enable resizable BAR,
> resulting in a maximum BAR size of 256MB. This patch adjusts the

s/This patch adjust/Adjust/

> maximum object size used in test conditions based on the available
> VRAM.
> 
> v2: Adjusted the subject name
> 
> v3: Inco-operated review comments [kamil]
> 
> v4: Fixed typo.
> 
> Signed-off-by: Sobin Thomas <sobin.thomas at intel.com>
> ---
>  tests/intel/xe_evict_ccs.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tests/intel/xe_evict_ccs.c b/tests/intel/xe_evict_ccs.c
> index 281d27015..841ed2997 100644
> --- a/tests/intel/xe_evict_ccs.c
> +++ b/tests/intel/xe_evict_ccs.c
> @@ -343,6 +343,35 @@ static void set_config(int fd, uint32_t flags, const struct param *param,
>  	igt_debug("nproc: %d, mem per proc: %dMB\n", nproc, config->mb_per_proc);
>  }
>  
> +static void adjust_params_for_vram_size(uint64_t vram_size)
> +{
> +	uint64_t vram_mb = vram_size / (1024 * 1024);
> +	int recommended_max_size_kb;
> +	bool user_set_max_size = (params.max_size_kb != MAX_OBJ_KB);

Maybe you should remember that user changed this?
What if user will give MAX_OBJ_KB as input param?

> +
> +	 /* max_object_mb = VRAM_mb / 64, clamped between 2MB and 256MB
> +	  * Formula works for all VRAM sizes with consistent behavior

Remove this 2nd sentence and make it a one-liner comment.

> +	  */
> +	int max_object_mb = vram_mb / MIN_OBJ_KB;
> +
> +	max_object_mb = max_t(int, 2, min_t(int, max_object_mb, 256));
> +	recommended_max_size_kb = max_object_mb * 1024;
> +
> +	igt_info("VRAM (%"PRIu64"MB): Calculated %d%% usage, %dMB max objects\n",
> +		 vram_mb, params.vram_percent, max_object_mb);
> +
> +	if (user_set_max_size) {

Warn only when user actually wants to have larger size, so add:

	if (user_set_max_size &&
	    recommended_max_size_kb < params.max_size_kb) {

> +		igt_warn("User specified max object size (%dKB) may not be"
> +				"optimal for %"PRIu64"MB VRAM (recommended: %dKB)\n",
> +				params.max_size_kb, vram_mb, recommended_max_size_kb);

Any reason for printing sizes in KB? Imho it is better to print
in MB or both.

Regards,
Kamil

> +	} else {
> +		params.max_size_kb = recommended_max_size_kb;
> +	}
> +
> +	igt_info("Final settings: %d%% VRAM, %dMB max object\n",
> +		 params.vram_percent, params.max_size_kb / 1024);
> +}
> +
>  static void evict_ccs(int fd, uint32_t flags, const struct param *param)
>  {
>  	struct config config;
> @@ -500,6 +529,7 @@ igt_main_args("bdDn:p:s:S:V", NULL, help_str, opt_handler, NULL)
>  		igt_require(xe_has_vram(fd));
>  		vram_size = xe_visible_vram_size(fd, 0);
>  		igt_assert(vram_size);
> +		adjust_params_for_vram_size(vram_size);
>  		has_flatccs = HAS_FLATCCS(intel_get_drm_devid(fd));
>  	}
>  
> -- 
> 2.34.1
>