[PATCH i-g-t v4 02/41] lib/vkms: Add minimal VKMS library and test device default files

[Kamil Konieczny]

Hi José,
On 2025-08-14 at 12:52:22 +0200, José Expósito wrote:
> Hi Kamil,
> 
> On Wed, Aug 13, 2025 at 03:28:26PM +0200, Kamil Konieczny wrote:
> > Hi José,
> > On 2025-08-07 at 09:45:11 +0200, José Expósito wrote:
> > > Create a library containing helpers for creating VKMS devices and
> > > configuring them dynamically using configfs.
> > > For the moment, add the minimal number of helpers to be able to start
> > > testing VKMS's configfs support: Create device, destroy device and
> > > destroy all devices.
> > > 
> > > Also, include the simplest possible test using those helpers (checking
> > > the device's default files) and the scaffolding required to generate
> > > the documentation.
> > > 
> > > Co-developed-by: Jim Shargo <jshargo at chromium.org>
> > > Signed-off-by: Jim Shargo <jshargo at chromium.org>
> > > Co-developed-by: Marius Vlad <marius.vlad at collabora.com>
> > > Signed-off-by: Marius Vlad <marius.vlad at collabora.com>
> > > Signed-off-by: José Expósito <jose.exposito89 at gmail.com>
> > > ---
> > >  lib/igt_vkms.c             | 206 +++++++++++++++++++++++++++++++++++++
> > >  lib/igt_vkms.h             |  27 +++++
> > >  lib/meson.build            |   1 +
> > >  meson.build                |   8 ++
> > >  tests/meson.build          |   2 +
> > >  tests/vkms/meson.build     |  13 +++
> > >  tests/vkms/vkms_configfs.c | 131 +++++++++++++++++++++++
> > 
> > I checked changes as they are only minimal, imho you could keep
> > Reviewed-by: Louis Chauvet <louis.chauvet at bootlin.com>
> > 
> > Also, you removed changes from testplan and docs building so
> > for build/meson changes
> > Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > 
> > Btw checkpatch suggests even one more const 
> > static const char * array should probably be static const char * const
> > but you could fix that later.
> 
> Thanks a lot for your reviews. Almost all patches are reviewed now.
> Let's see if the DRM series get merged soon and we can merge this
> one as well :)
> 
> About the additional const, I noticed it, but then ARRAY_SIZE() would
> trigger a warning about that extra const, so I decided to ignore
> checkpatch and avoid unnecessary refactors.

Makes sense, thx for explanation.

Regards,
Kamil

> 
> Thanks,
> Jose
> 
> > Regards,
> > Kamil
> > 
> > >  7 files changed, 388 insertions(+)
> > >  create mode 100644 lib/igt_vkms.c
> > >  create mode 100644 lib/igt_vkms.h
> > >  create mode 100644 tests/vkms/meson.build
> > >  create mode 100644 tests/vkms/vkms_configfs.c
> > > 
> > > diff --git a/lib/igt_vkms.c b/lib/igt_vkms.c
> > > new file mode 100644
> > > index 000000000..03931d2e4
> > > --- /dev/null
> > > +++ b/lib/igt_vkms.c
> > > @@ -0,0 +1,206 @@
> > > +// SPDX-License-Identifier: MIT
> > > +/*
> > > + * Copyright © 2023 Google LLC.
> > > + * Copyright © 2023 Collabora, Ltd.
> > > + * Copyright © 2024-2025 Red Hat, Inc.
> > > + */
> > > +

[cut]