[PATCH i-g-t 0/4] Add initial Panthor tests

[Juha-Pekka Heikkilä]

Hi Daniel,

I was taking a brief look at your patches. I didn't spot anything
terribly wrong, and as I figure this is new platform you will build
into igt and nothing current seems to be broken from your patches so
all look ok. Still, few comments I did come up with.

On lib new public functions there's been expectation for them to
include the comment block. Those small detail 'nitpicking', people
have been favoring c style comments instead of c++ that is /* */
instead of //. For subtests there's supposing to be igt_describe(..)
before the test. As for that absence of checkpatch, we've been using
just the version from kernel.

Changes on those meson scripts I hope Kamil notice and could take
quick look, I think Kamil knows best the life of those build scripts.
Generally I think it would be good if on the last patch you could
separate changes in lib and tests to different patches. Imo it would
be easier to deal with, ie if there come some wishes from someone for
some changes in test (like you now got some comments), lib could
anyway be merged if they're not in the same patch. For overall how the
tests otherwise look like I have zero comment since I don't know
anything about Panthor. Would be good idea to add comment block for
subtests to tell what the subtest attempt to test at least when it's
not obvious.

/Juha-Pekka

On Thu, Aug 28, 2025 at 4:04 PM Daniel Almeida
<daniel.almeida at collabora.com> wrote:
>
>
> This series adds basic Panthor tests. In particular, these are being
> used to test both Panthor and Tyr, i.e.: the new Rust GPU driver that
> implements Panthor's uAPI. Most of the initial tests were chosen in
> order to have something to test Tyr with, but this series lays the
> groundwork so that more interesting tests can be added to test more of
> Panthor itself.
>
> Also, please note that this is my first IGT patch, so apologies in
> advance in case I forgot to follow any IGT-specific workflow when
> submitting this. I don't see a checkpatch.pl equivalent, so there was
> nothing to check this submission with as far as I am aware.
>
> Daniel Almeida (4):
>   lib: add support for opening Panthor devices
>   tests: panthor: add initial infrastructure
>   lib: initial panthor infrastructure
>   tests/panthor: add panthor tests
>
>  lib/drmtest.c                 |   1 +
>  lib/drmtest.h                 |   1 +
>  lib/igt_panthor.c             | 150 +++++++++++++++++++
>  lib/igt_panthor.h             |  28 ++++
>  lib/meson.build               |   1 +
>  meson.build                   |   8 ++
>  tests/meson.build             |   2 +
>  tests/panthor/meson.build     |  15 ++
>  tests/panthor/panthor_gem.c   |  59 ++++++++
>  tests/panthor/panthor_group.c | 264 ++++++++++++++++++++++++++++++++++
>  tests/panthor/panthor_query.c |  25 ++++
>  tests/panthor/panthor_vm.c    |  73 ++++++++++
>  12 files changed, 627 insertions(+)
>  create mode 100644 lib/igt_panthor.c
>  create mode 100644 lib/igt_panthor.h
>  create mode 100644 tests/panthor/meson.build
>  create mode 100644 tests/panthor/panthor_gem.c
>  create mode 100644 tests/panthor/panthor_group.c
>  create mode 100644 tests/panthor/panthor_query.c
>  create mode 100644 tests/panthor/panthor_vm.c
>
> --
> 2.50.1
>