[PATCH i-g-t] tests/kms_display_modes: Add logs to skips

Samala, Pranay pranay.samala at intel.com
Fri Feb 7 03:31:48 UTC 2025


Hi Jeevan,

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Jeevan B
> Sent: Thursday, February 6, 2025 8:54 PM
> To: igt-dev at lists.freedesktop.org
> Cc: B, Jeevan <jeevan.b at intel.com>
> Subject: [PATCH i-g-t] tests/kms_display_modes: Add logs to skips
> 
> Add igt_require check to ensure that test criteria are met before execution. If the
> required is not met, skip the test with log.

This commit message looks like the definition of the igt_require check.
Please define why you are using it here.

Regards,
Pranay.
> 
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> ---
>  tests/kms_display_modes.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c index
> e41c60cc0..117f82325 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -335,8 +335,10 @@ igt_main
>  	}
> 
>  	igt_describe("Test for validating display extended mode with a pair of
> connected displays");
> -	igt_subtest_with_dynamic("extended-mode-basic")
> +	igt_subtest_with_dynamic("extended-mode-basic") {
> +		igt_require_f(count > 1, "Minimum 2 outputs are required\n");
>  		run_extendedmode_test(&data);
> +	}
> 
>  	igt_describe("Negative test for validating display extended mode with a
> pair of connected "
>  		     "2k-4k or 4k-4k displays");
> --
> 2.25.1



More information about the igt-dev mailing list