Re: [PATCH i-g-t] tests/kms_display_modes: Add check for ≥2 outputs in extended mode test

[Sharma, Swati2]

LGTM

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>


On 10-02-2025 11:40 am, Jeevan B wrote:
> extended mode test needs minimum 2 display to run, so add igt_require
> to check if the required criteria is met or not.
>
> v2: Fix commit message.
> v3: Update subject.
>
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> ---
>   tests/kms_display_modes.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index e41c60cc0..117f82325 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -335,8 +335,10 @@ igt_main
>   	}
>   
>   	igt_describe("Test for validating display extended mode with a pair of connected displays");
> -	igt_subtest_with_dynamic("extended-mode-basic")
> +	igt_subtest_with_dynamic("extended-mode-basic") {
> +		igt_require_f(count > 1, "Minimum 2 outputs are required\n");
>   		run_extendedmode_test(&data);
> +	}
>   
>   	igt_describe("Negative test for validating display extended mode with a pair of connected "
>   		     "2k-4k or 4k-4k displays");