[CI i-g-t 00/10] Add igt_runner's cmdline to results

Lucas De Marchi lucas.demarchi at intel.com
Mon Feb 10 19:27:39 UTC 2025


On Fri, Feb 07, 2025 at 03:09:34PM -0800, Lucas De Marchi wrote:
>Help devs to reproduce what CI is running by dumping what is the command
>line being used. While it's true that in the shard case we don't have
>the testlist, just seeing the right incantation of command line is a
>great improvement.
>
>I plan to follow this with the env vars, but first want to get this
>in. It seems we already have an environment.txt saved, however that
>doesn't contain the igt_runner's env, only options passed via -e to
>igt_runner which is then forwarded to each test. I'm wondering if this
>is a source of bugs when using igt_resume:  if the environment doesn't
>match, it will run with different options on each execution. (answer:
>yes, it is a source of bugs if the exact environment is not re-created
>for running igt_resume)
>
>v2:
>  - Fix more leaks as prep commits
>  - Fix leaking argv that got lost in all other pre-existent leaks
>  - Add dummy array to the reference.json files so it passes runner's
>    own tests.
>
>v3:
>  - Better split patches and reword commit messages according to reviews
>    by Gustavo and Peter
>  - Add generic escape/unescape functions to be used for metadata.txt.
>    Besides preparing for cmdline, it fixes other uses of \n.
>  - Provide a single macro to parse array, which adds the proper code
>    to parse both the array items and the length
>
>CI: minor adjustements. Let's make sure it passes CI.


Thank you for reviews and feeback. Patches applied.

Lucas De Marchi


More information about the igt-dev mailing list