[PATCH i-g-t] tests/intel/kms_draw_crc: Add more logs to skips/failure
Krzysztof Karas
krzysztof.karas at intel.com
Thu Feb 13 12:01:20 UTC 2025
Hi Pranay,
> Having some logs for test failures or skips would
> make debugging much easier.
I think the commit message is too broad for the changes that you
make. Something like:
"Add a flag to check if display supports any format and
modifier."
would better reflect the purpose of the code changes.
> + bool flag = false;
"flag" is too generic and does not hint at what it's usage is.
You could name this variable "found_supported_format" or
"no_supported_formats" and start with a "true" value, which is
flipped when a supported format is found.
Best regards,
Krzysztof
More information about the igt-dev
mailing list