[PATCH i-g-t 5/5] tests/intel/kms_cdclk: Use igt_get_max_cdclk()

Nautiyal, Ankit K ankit.k.nautiyal at intel.com
Mon Feb 17 08:36:38 UTC 2025


On 2/13/2025 4:38 PM, Swati Sharma wrote:
> Replace hardcoded max cdclk freq with one computed from debugfs.
> in igt_get_max_cdclk(). Also, add same condition for
> all_outputs subtest.
>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>


> ---
>   tests/intel/kms_cdclk.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
> index eeb1ecd69..3596fd30c 100644
> --- a/tests/intel/kms_cdclk.c
> +++ b/tests/intel/kms_cdclk.c
> @@ -53,7 +53,6 @@ IGT_TEST_DESCRIPTION("Test cdclk features : crawling and squashing");
>   #define HDISPLAY_4K	3840
>   #define VDISPLAY_4K	2160
>   #define VREFRESH	60
> -#define MAX_CDCLK_4K	307200
>   
>   /* Test flags */
>   enum {
> @@ -250,7 +249,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
>   	igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
>   
>   	/* cdclk should bump */
> -	if (cdclk_new != MAX_CDCLK_4K)
> +	if (cdclk_new != igt_get_max_cdclk(debugfs_fd))
>   		igt_assert_lt(cdclk_ref, cdclk_new);
>   
>   	/* cleanup */
> @@ -341,7 +340,8 @@ static void test_mode_transition_on_all_outputs(data_t *data)
>   	igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
>   
>   	/* cdclk should bump */
> -	igt_assert_lt(cdclk_ref, cdclk_new);
> +	if (cdclk_new != igt_get_max_cdclk(debugfs_fd))
> +		igt_assert_lt(cdclk_ref, cdclk_new);
>   
>   	do_cleanup_display(display);
>   	igt_remove_fb(data->drm_fd, &fb);


More information about the igt-dev mailing list