[PATCH i-g-t v3 2/5] runner/settings: Constify absolute_path parameter

Naladala Ramanaidu ramanaidu.naladala at intel.com
Tue Feb 18 21:53:46 UTC 2025


Make absolute_path a const char*, this ensures the input path
remains unmodified, enhancing code safety and clarity.

v2: Update commit subject.  (kamil)
v3: Update commit message.  (Kamil)

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
---
 runner/settings.c | 2 +-
 runner/settings.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/runner/settings.c b/runner/settings.c
index a2fddcaf6..c1f3be77a 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -579,7 +579,7 @@ static char *_basename(const char *path)
 	return tmpname;
 }
 
-char *absolute_path(char *path)
+char *absolute_path(const char *path)
 {
 	char *result = NULL;
 	char *base, *dir;
diff --git a/runner/settings.h b/runner/settings.h
index 2266118a7..42c96665a 100644
--- a/runner/settings.h
+++ b/runner/settings.h
@@ -140,7 +140,7 @@ bool parse_options(int argc, char **argv,
 bool validate_settings(struct settings *settings);
 
 /* TODO: Better place for this */
-char *absolute_path(char *path);
+char *absolute_path(const char *path);
 
 /**
  * serialize_settings:
-- 
2.43.0



More information about the igt-dev mailing list